public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Patrick Mansfield <patmans@us.ibm.com>,
	James Bottomley <James.Bottomley@steeleye.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2.5.17] Making SCSI not copy the request structure
Date: Wed, 22 May 2002 23:14:45 -0400	[thread overview]
Message-ID: <20020522231445.A3014@redhat.com> (raw)
In-Reply-To: <E17Ahv7-0003Lb-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Thu, May 23, 2002 at 03:01:37AM +0100

On Thu, May 23, 2002 at 03:01:37AM +0100, Alan Cox wrote:
> One thing I see consistently as a problem in the block layers in 2.4 is
> that there is no way to say "thanks for the request you just threw at me
> but Im busy right now" and to flag "busy/idle".
> 
> The network layer has a clean way to say "Im busy dont feed me",
> "Im no longer busy, feed me" and also "thanks but I've just discovered I
> am in fact busy have this request back anbd feed it me later"

No, that does in fact exist.  At least in the new scsi eh code you are 
allowed to return a non-0 value from your low level driver's 
queuecommand() routine.  On a non-0 return, the mid layer throws the 
command onto the mlqueue and waits to send it until the mid layer 
processes a completion event from you (or there might also be a timeout, 
I'm not sure, but I would hope there is also a timeout since otherwise 
returning non-0 with no outstanding commands on a device because your 
driver is busy with something else could cause a queue to hang).  Anyway, 
it's there even if I never did personally use it since my driver used the 
old eh code ;-)

-- 
  Doug Ledford <dledford@redhat.com>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606
  

  reply	other threads:[~2002-05-23  3:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-21 23:11 [PATCH 2.5.17] Making SCSI not copy the request structure James Bottomley
2002-05-22 22:44 ` Patrick Mansfield
2002-05-22 22:53   ` Doug Ledford
2002-05-23  2:01     ` Alan Cox
2002-05-23  3:14       ` Doug Ledford [this message]
2002-05-24 15:32         ` Alan Cox
2002-05-24 15:56           ` James Bottomley
2002-05-23  0:06   ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2002-05-23  9:18 Aron Zeh
2002-05-23 12:44 ` James Bottomley
2002-05-24  7:52 Aron Zeh
2002-05-24  8:34 ` rakesh rakesh
2002-05-24 13:17   ` James Bottomley
2002-05-24 13:00 ` James Bottomley
2002-05-24  9:35 Aron Zeh
2002-05-24 16:44 ` Patrick Mansfield
2002-05-31 12:04 Aron Zeh
     [not found] <OFF6A89763.CD0EBEF7-ONC1256BCA.003CD69A@de.ibm.com>
2002-05-31 13:57 ` James Bottomley
2002-05-31 16:57 Aron Zeh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020522231445.A3014@redhat.com \
    --to=dledford@redhat.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox