Re: [RFC][RFT] scsi_scan.c cleanup/rewrite

Re: [RFC][RFT] scsi_scan.c cleanup/rewrite

[Martin Peschke3]

Hi,

without having read the patch in detail, I think it's the a right idea
to make a rewrite. The old functions are too long, have too much
indentations,
are too complex, have too much parameters (remember scan_scsi_single),
and have not been designed to fit such requirements as support for report
luns.

A suggestion:
In my opinion, such a patch would avail from a cleanup of the SCSI stack
data structures which should be done in the first place. I would like to
see
all those lists rethought and rewritten using list_heads and introducing
some locks which are required to protect changes to these lists.


Mit freundlichen Grüßen / with kind regards

Martin Peschke

IBM Deutschland Entwicklung GmbH
Linux for eServer Development
Phone: +49-(0)7031-16-2349


patman@beaverton.ibm.com@vger.kernel.org on 06/20/2002 01:42:35 AM

Please respond to patman@beaverton.ibm.com

Sent by:    linux-scsi-owner@vger.kernel.org


To:    linux-scsi@vger.kernel.org
cc:
Subject:    [RFC][RFT] scsi_scan.c cleanup/rewrite



Hi -

I cleaned up scsi_scan.c, pretty much a rewrite of the code.

Any comments or flames?

Do you think the style changes moves us to far away from current
linux scsi style?

Should we keep the naming styles, such as SDpnt, SRpnt, SHpnt, etc?

The diffs are larger than the file itself, but let me know if I should
post the diffs. Changes were tested with 2.5.22 (the changes are also
compatible with 2.5.23, but I haven't tried running 2.5.23).

The only functional change (should be) adding support for BFLAGS_LARGELUN,
it was defined before, but not used, otherwise it should be the complete
functional equivalent of the current 2.5.x code.

I also removed the unused BFLAGS_NODISK.

I did not fully cleanup the device_list[] table initialization (not sure
how to make that table ever look clean), plus James Bottomley was talking
about moving it into user space.

Tested with IBM 3542 (multi-LUN FC disk array) and SEAGATE ST118273 FC
drives on qla2200 and qla2300 with qla v6 beta drivers (modified for
2.5.x), both with and without REPORT LUN built into the kernel.

Plus, the boot disk is a IBM-PSG ST318203LC on an AIC Adaptec 7896.

If you have any of the odd-ball devices in device_list or any SCSI devices
currently working under 2.5.x, I would appreciate further testing of the
code.

Thanks.

-- Patrick Mansfield





-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC][RFT] scsi_scan.c cleanup/rewrite

[Doug Ledford]

On Thu, Jun 20, 2002 at 10:49:55AM +0200, Martin Peschke3 wrote:
> A suggestion:
> In my opinion, such a patch would avail from a cleanup of the SCSI stack
> data structures which should be done in the first place. I would like to
> see
> all those lists rethought and rewritten using list_heads and introducing
> some locks which are required to protect changes to these lists.

That's coming.  At least, I'm working on it right now so it's coming from 
me fairly soon, if not from someone else sooner.


-- 
  Doug Ledford <dledford@redhat.com>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606
  

[RFC][RFT] scsi_scan.c cleanup/rewrite

[Patrick Mansfield]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

Hi -

I cleaned up scsi_scan.c, pretty much a rewrite of the code.

Any comments or flames?

Do you think the style changes moves us to far away from current
linux scsi style?

Should we keep the naming styles, such as SDpnt, SRpnt, SHpnt, etc?

The diffs are larger than the file itself, but let me know if I should
post the diffs. Changes were tested with 2.5.22 (the changes are also
compatible with 2.5.23, but I haven't tried running 2.5.23).

The only functional change (should be) adding support for BFLAGS_LARGELUN,
it was defined before, but not used, otherwise it should be the complete
functional equivalent of the current 2.5.x code.

I also removed the unused BFLAGS_NODISK.

I did not fully cleanup the device_list[] table initialization (not sure
how to make that table ever look clean), plus James Bottomley was talking
about moving it into user space.

Tested with IBM 3542 (multi-LUN FC disk array) and SEAGATE ST118273 FC
drives on qla2200 and qla2300 with qla v6 beta drivers (modified for 
2.5.x), both with and without REPORT LUN built into the kernel.

Plus, the boot disk is a IBM-PSG ST318203LC on an AIC Adaptec 7896.

If you have any of the odd-ball devices in device_list or any SCSI devices
currently working under 2.5.x, I would appreciate further testing of the code.

Thanks.

-- Patrick Mansfield

[-- Attachment #2: scsi_scan.c.gz --]
[-- Type: application/octet-stream, Size: 13134 bytes --]