public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Trivial Russell <rusty@rustcorp.com.au>
To: linux-scsi@vger.kernel.org, dledford@redhat.com
Subject: [TRIVIAL] Re: aic7xxx gcc3 warning fix
Date: Mon, 15 Jul 2002 17:09:48 +1000	[thread overview]
Message-ID: <20020715082121.7DC7C4277@lists.samba.org> (raw)


[ Hi guys: recent gccs warn about multiline string literals (a
  deprecated gcc extension).  This patch was submitted via the Trivial
  Patch Monkey: please reply if you want me to push it to Linus. --RR ].

From: (via Rusty) Arnaud Launay <asl@launay.org>

  Le Tue, Jun 04, 2002 at 08:53:19AM +1000, Rusty Russell a écrit:
  > > Patch enclosed corrects the following warning in 2.5.20:
  > > aic7xxx_linux.c:401:27: warning: multi-line string literals are deprecated
  > Wrong fix: remove the commas at the ends of lines...
  
  Hm, found only one other driver using multilines (drivers/media/video/c-qcam.c),
  patch enclosed uses the same kind of params.
  
  I hope I do not bother you, else just tell me.
  
  Regards,
  	Arnaud.
  -- 
  Flexion, extension !

--- trivial-2.5.25/drivers/scsi/aic7xxx/aic7xxx_linux.c.orig	Mon Jul 15 17:02:49 2002
+++ trivial-2.5.25/drivers/scsi/aic7xxx/aic7xxx_linux.c	Mon Jul 15 17:02:49 2002
@@ -398,26 +398,26 @@
 MODULE_LICENSE("Dual BSD/GPL");
 #endif
 MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
-	verbose			Enable verbose/diagnostic logging
-	no_probe		Disable EISA/VLB controller probing
-	no_reset		Supress initial bus resets
-	extended		Enable extended geometry on all controllers
-	periodic_otag		Send an ordered tagged transaction periodically
-				to prevent tag starvation.  This may be
-				required by some older disk drives/RAID arrays. 
-	reverse_scan		Sort PCI devices highest Bus/Slot to lowest
-	tag_info:<tag_str>	Set per-target tag depth
-	seltime:<int>		Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
-	Sample /etc/modules.conf line:
-		Enable verbose logging
-		Disable EISA/VLB probing
-		Set tag depth on Controller 2/Target 2 to 10 tags
-		Shorten the selection timeout to 128ms from its default of 256
-
-	options aic7xxx='"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1"'
-");
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.n
+	verbose			Enable verbose/diagnostic loggingn
+	no_probe		Disable EISA/VLB controller probingn
+	no_reset		Supress initial bus resetsn
+	extended		Enable extended geometry on all controllersn
+	periodic_otag		Send an ordered tagged transaction periodicallyn
+				to prevent tag starvation.  This may ben
+				required by some older disk drives/RAID arrays. n
+	reverse_scan		Sort PCI devices highest Bus/Slot to lowestn
+	tag_info:<tag_str>	Set per-target tag depthn
+	seltime:<int>		Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)n
+n
+	Sample /etc/modules.conf line:n
+		Enable verbose loggingn
+		Disable EISA/VLB probingn
+		Set tag depth on Controller 2/Target 2 to 10 tagsn
+		Shorten the selection timeout to 128ms from its default of 256n
+n
+	options aic7xxx='"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1"'n"
+);
 #endif
 
 static void ahc_linux_handle_scsi_status(struct ahc_softc *,
-- 
  Don't blame me: the Monkey is driving
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2002-07-15  7:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-15  7:09 Rusty Trivial Russell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-07-18  3:03 [TRIVIAL] Re: aic7xxx gcc3 warning fix Rusty Trivial Russell
2002-07-26  6:38 Rusty Trivial Russell
2002-07-26  9:17 ` Christoph Hellwig
2002-07-26 19:58   ` Doug Ledford
2002-07-27  4:14   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020715082121.7DC7C4277@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=dledford@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox