Re: 2 PATCHES: fix request_tranferlength

Willem Riede
2002-07-21T22:52:33Z

On 2002.07.21 18:15 Matthew Dharm wrote:
> These two BK patches fix two instances where a command is issued with an
> incorrect transfer length. The first is in the probing code... the section
> where we make the second INQUIRY request for the full INQUIRY data. The
> second is in sd.c where the MODE_SENSE request is issued.
>
[snip]
> diff -Nru a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> --- a/drivers/scsi/sd.c Sun Jul 21 00:55:44 2002
> +++ b/drivers/scsi/sd.c Sun Jul 21 00:55:44 2002
> @@ -1102,7 +1102,7 @@
> SRpnt->sr_data_direction = SCSI_DATA_READ;
>
> scsi_wait_req(SRpnt, (void *) cmd, (void *) buffer,
> - 512, SD_TIMEOUT, MAX_RETRIES);
> + 255, SD_TIMEOUT, MAX_RETRIES);
>
> the_result = SRpnt->sr_result;
>
Matt,

is asking for an odd number of bytes a good idea? There have been problems
with doing so on OnStream tape drives...

Thanks, Willem Riede.