* [TRIVIAL] Re: aic7xxx gcc3 warning fix
@ 2002-07-15 7:09 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-07-15 7:09 UTC (permalink / raw)
To: linux-scsi, dledford
[ Hi guys: recent gccs warn about multiline string literals (a
deprecated gcc extension). This patch was submitted via the Trivial
Patch Monkey: please reply if you want me to push it to Linus. --RR ].
From: (via Rusty) Arnaud Launay <asl@launay.org>
Le Tue, Jun 04, 2002 at 08:53:19AM +1000, Rusty Russell a écrit:
> > Patch enclosed corrects the following warning in 2.5.20:
> > aic7xxx_linux.c:401:27: warning: multi-line string literals are deprecated
> Wrong fix: remove the commas at the ends of lines...
Hm, found only one other driver using multilines (drivers/media/video/c-qcam.c),
patch enclosed uses the same kind of params.
I hope I do not bother you, else just tell me.
Regards,
Arnaud.
--
Flexion, extension !
--- trivial-2.5.25/drivers/scsi/aic7xxx/aic7xxx_linux.c.orig Mon Jul 15 17:02:49 2002
+++ trivial-2.5.25/drivers/scsi/aic7xxx/aic7xxx_linux.c Mon Jul 15 17:02:49 2002
@@ -398,26 +398,26 @@
MODULE_LICENSE("Dual BSD/GPL");
#endif
MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
- verbose Enable verbose/diagnostic logging
- no_probe Disable EISA/VLB controller probing
- no_reset Supress initial bus resets
- extended Enable extended geometry on all controllers
- periodic_otag Send an ordered tagged transaction periodically
- to prevent tag starvation. This may be
- required by some older disk drives/RAID arrays.
- reverse_scan Sort PCI devices highest Bus/Slot to lowest
- tag_info:<tag_str> Set per-target tag depth
- seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
- Sample /etc/modules.conf line:
- Enable verbose logging
- Disable EISA/VLB probing
- Set tag depth on Controller 2/Target 2 to 10 tags
- Shorten the selection timeout to 128ms from its default of 256
-
- options aic7xxx='"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1"'
-");
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.n
+ verbose Enable verbose/diagnostic loggingn
+ no_probe Disable EISA/VLB controller probingn
+ no_reset Supress initial bus resetsn
+ extended Enable extended geometry on all controllersn
+ periodic_otag Send an ordered tagged transaction periodicallyn
+ to prevent tag starvation. This may ben
+ required by some older disk drives/RAID arrays. n
+ reverse_scan Sort PCI devices highest Bus/Slot to lowestn
+ tag_info:<tag_str> Set per-target tag depthn
+ seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)n
+n
+ Sample /etc/modules.conf line:n
+ Enable verbose loggingn
+ Disable EISA/VLB probingn
+ Set tag depth on Controller 2/Target 2 to 10 tagsn
+ Shorten the selection timeout to 128ms from its default of 256n
+n
+ options aic7xxx='"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1"'n"
+);
#endif
static void ahc_linux_handle_scsi_status(struct ahc_softc *,
--
Don't blame me: the Monkey is driving
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL] Re: aic7xxx gcc3 warning fix
@ 2002-07-18 3:03 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-07-18 3:03 UTC (permalink / raw)
To: Linus Torvalds; +Cc: dledford, linux-scsi
[ This one should have the eol \'s still in place (thanks Alan). ]
From: (via Rusty) Arnaud Launay <asl@launay.org>
Le Tue, Jun 04, 2002 at 08:53:19AM +1000, Rusty Russell a écrit:
> > Patch enclosed corrects the following warning in 2.5.20:
> > aic7xxx_linux.c:401:27: warning: multi-line string literals are deprecated
> Wrong fix: remove the commas at the ends of lines...
Hm, found only one other driver using multilines (drivers/media/video/c-qcam.c),
patch enclosed uses the same kind of params.
I hope I do not bother you, else just tell me.
Regards,
Arnaud.
--
Flexion, extension !
--- trivial-2.5.26/drivers/scsi/aic7xxx/aic7xxx_linux.c.orig Thu Jul 18 13:00:30 2002
+++ trivial-2.5.26/drivers/scsi/aic7xxx/aic7xxx_linux.c Thu Jul 18 13:00:30 2002
@@ -398,26 +398,26 @@
MODULE_LICENSE("Dual BSD/GPL");
#endif
MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
- verbose Enable verbose/diagnostic logging
- no_probe Disable EISA/VLB controller probing
- no_reset Supress initial bus resets
- extended Enable extended geometry on all controllers
- periodic_otag Send an ordered tagged transaction periodically
- to prevent tag starvation. This may be
- required by some older disk drives/RAID arrays.
- reverse_scan Sort PCI devices highest Bus/Slot to lowest
- tag_info:<tag_str> Set per-target tag depth
- seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
- Sample /etc/modules.conf line:
- Enable verbose logging
- Disable EISA/VLB probing
- Set tag depth on Controller 2/Target 2 to 10 tags
- Shorten the selection timeout to 128ms from its default of 256
-
- options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'
-");
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.\n\
+ verbose Enable verbose/diagnostic logging\n\
+ no_probe Disable EISA/VLB controller probing\n\
+ no_reset Supress initial bus resets\n\
+ extended Enable extended geometry on all controllers\n\
+ periodic_otag Send an ordered tagged transaction periodically\n\
+ to prevent tag starvation. This may be\n\
+ required by some older disk drives/RAID arrays. \n\
+ reverse_scan Sort PCI devices highest Bus/Slot to lowest\n\
+ tag_info:<tag_str> Set per-target tag depth\n\
+ seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)\n\
+\n\
+ Sample /etc/modules.conf line:\n\
+ Enable verbose logging\n\
+ Disable EISA/VLB probing\n\
+ Set tag depth on Controller 2/Target 2 to 10 tags\n\
+ Shorten the selection timeout to 128ms from its default of 256\n\
+\n\
+ options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'\n"
+);
#endif
static void ahc_linux_handle_scsi_status(struct ahc_softc *,
--
Don't blame me: the Monkey is driving
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL] Re: aic7xxx gcc3 warning fix
@ 2002-07-26 6:38 Rusty Trivial Russell
2002-07-26 9:17 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-07-26 6:38 UTC (permalink / raw)
To: Linus Torvalds; +Cc: dledford, linux-scsi
From: Arnaud Launay <asl@launay.org>
Le Tue, Jun 04, 2002 at 08:53:19AM +1000, Rusty Russell a écrit:
> > Patch enclosed corrects the following warning in 2.5.20:
> > aic7xxx_linux.c:401:27: warning: multi-line string literals are deprecated
> Wrong fix: remove the commas at the ends of lines...
Hm, found only one other driver using multilines (drivers/media/video/c-qcam.c),
patch enclosed uses the same kind of params.
I hope I do not bother you, else just tell me.
Regards,
Arnaud.
--
Flexion, extension !
--- trivial-2.5.28/drivers/scsi/aic7xxx/aic7xxx_linux.c.orig Fri Jul 26 16:36:40 2002
+++ trivial-2.5.28/drivers/scsi/aic7xxx/aic7xxx_linux.c Fri Jul 26 16:36:40 2002
@@ -398,26 +398,26 @@
MODULE_LICENSE("Dual BSD/GPL");
#endif
MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
- verbose Enable verbose/diagnostic logging
- no_probe Disable EISA/VLB controller probing
- no_reset Supress initial bus resets
- extended Enable extended geometry on all controllers
- periodic_otag Send an ordered tagged transaction periodically
- to prevent tag starvation. This may be
- required by some older disk drives/RAID arrays.
- reverse_scan Sort PCI devices highest Bus/Slot to lowest
- tag_info:<tag_str> Set per-target tag depth
- seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
- Sample /etc/modules.conf line:
- Enable verbose logging
- Disable EISA/VLB probing
- Set tag depth on Controller 2/Target 2 to 10 tags
- Shorten the selection timeout to 128ms from its default of 256
-
- options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'
-");
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.\n\
+ verbose Enable verbose/diagnostic logging\n\
+ no_probe Disable EISA/VLB controller probing\n\
+ no_reset Supress initial bus resets\n\
+ extended Enable extended geometry on all controllers\n\
+ periodic_otag Send an ordered tagged transaction periodically\n\
+ to prevent tag starvation. This may be\n\
+ required by some older disk drives/RAID arrays. \n\
+ reverse_scan Sort PCI devices highest Bus/Slot to lowest\n\
+ tag_info:<tag_str> Set per-target tag depth\n\
+ seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)\n\
+\n\
+ Sample /etc/modules.conf line:\n\
+ Enable verbose logging\n\
+ Disable EISA/VLB probing\n\
+ Set tag depth on Controller 2/Target 2 to 10 tags\n\
+ Shorten the selection timeout to 128ms from its default of 256\n\
+\n\
+ options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'\n"
+);
#endif
static void ahc_linux_handle_scsi_status(struct ahc_softc *,
--
Don't blame me: the Monkey is driving
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL] Re: aic7xxx gcc3 warning fix
2002-07-26 6:38 [TRIVIAL] Re: aic7xxx gcc3 warning fix Rusty Trivial Russell
@ 2002-07-26 9:17 ` Christoph Hellwig
2002-07-26 19:58 ` Doug Ledford
2002-07-27 4:14 ` Rusty Russell
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2002-07-26 9:17 UTC (permalink / raw)
To: Rusty Trivial Russell; +Cc: Linus Torvalds, dledford, linux-scsi
On Fri, Jul 26, 2002 at 04:38:32PM +1000, Rusty Trivial Russell wrote:
> MODULE_LICENSE("Dual BSD/GPL");
> #endif
> MODULE_PARM(aic7xxx, "s");
> -MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
> - verbose Enable verbose/diagnostic logging
> - no_probe Disable EISA/VLB controller probing
> - no_reset Supress initial bus resets
> - extended Enable extended geometry on all controllers
> - periodic_otag Send an ordered tagged transaction periodically
> - to prevent tag starvation. This may be
> - required by some older disk drives/RAID arrays.
> - reverse_scan Sort PCI devices highest Bus/Slot to lowest
> - tag_info:<tag_str> Set per-target tag depth
> - seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
> -
> - Sample /etc/modules.conf line:
> - Enable verbose logging
> - Disable EISA/VLB probing
> - Set tag depth on Controller 2/Target 2 to 10 tags
> - Shorten the selection timeout to 128ms from its default of 256
> -
> - options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'
> -");
> +MODULE_PARM_DESC(aic7xxx, "period delimited, options string.\n\
> + verbose Enable verbose/diagnostic logging\n\
> + no_probe Disable EISA/VLB controller probing\n\
> + no_reset Supress initial bus resets\n\
> + extended Enable extended geometry on all controllers\n\
> + periodic_otag Send an ordered tagged transaction periodically\n\
> + to prevent tag starvation. This may be\n\
> + required by some older disk drives/RAID arrays. \n\
> + reverse_scan Sort PCI devices highest Bus/Slot to lowest\n\
> + tag_info:<tag_str> Set per-target tag depth\n\
> + seltime:<int> Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)\n\
> +\n\
> + Sample /etc/modules.conf line:\n\
> + Enable verbose logging\n\
> + Disable EISA/VLB probing\n\
> + Set tag depth on Controller 2/Target 2 to 10 tags\n\
> + Shorten the selection timeout to 128ms from its default of 256\n\
> +\n\
> + options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'\n"
> +);
> #endif
Can't we just remove this stupid option parsing entirely in 2.5 and make it
take sane module options?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL] Re: aic7xxx gcc3 warning fix
2002-07-26 9:17 ` Christoph Hellwig
@ 2002-07-26 19:58 ` Doug Ledford
2002-07-27 4:14 ` Rusty Russell
1 sibling, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2002-07-26 19:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Rusty Trivial Russell, Linus Torvalds, linux-scsi
On Fri, Jul 26, 2002 at 10:17:54AM +0100, Christoph Hellwig wrote:
> Can't we just remove this stupid option parsing entirely in 2.5 and make it
> take sane module options?
And just how do you define sane module options for a driver that is both
module and built in capable and that should support the same set of
options in both places without exceeding the maximum linux command line
length in either place?
--
Doug Ledford <dledford@redhat.com> 919-754-3700 x44233
Red Hat, Inc.
1801 Varsity Dr.
Raleigh, NC 27606
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL] Re: aic7xxx gcc3 warning fix
2002-07-26 9:17 ` Christoph Hellwig
2002-07-26 19:58 ` Doug Ledford
@ 2002-07-27 4:14 ` Rusty Russell
1 sibling, 0 replies; 6+ messages in thread
From: Rusty Russell @ 2002-07-27 4:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: dledford, linux-scsi
In message <20020726101754.A6596@infradead.org> you write:
> Can't we just remove this stupid option parsing entirely in 2.5 and make it
> take sane module options?
Yes. I will be updating my PARAM() patches RSN.
Of course, you have to make sure the boot command length limit is
sane, too.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-07-27 4:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-26 6:38 [TRIVIAL] Re: aic7xxx gcc3 warning fix Rusty Trivial Russell
2002-07-26 9:17 ` Christoph Hellwig
2002-07-26 19:58 ` Doug Ledford
2002-07-27 4:14 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2002-07-18 3:03 Rusty Trivial Russell
2002-07-15 7:09 Rusty Trivial Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox