From: Patrick Mansfield <patmans@us.ibm.com>
To: linux-scsi@vger.kernel.org, zaitcev@redhat.com
Subject: Re: GFP_ATOMIC allocations...
Date: Fri, 30 Aug 2002 09:22:57 -0700 [thread overview]
Message-ID: <20020830092257.A19730@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <20020828214215.A31167@redhat.com>; from dledford@redhat.com on Wed, Aug 28, 2002 at 09:42:15PM -0400
On Wed, Aug 28, 2002 at 09:42:15PM -0400, Doug Ledford wrote:
> On Wed, Aug 28, 2002 at 05:47:37PM -0700, Patrick Mansfield wrote:
> > So, you think all (or most) of the GFP_ATOMIC's in scsi_scan.c should
> > be GFP_KERNEL?
>
>
> > All the kmalloc calls should be at boot time, or via
> > insmod.
>
> Right, process context with no locks held.
>
There was past discussion about calling into scsi_build_commandblocks()
while not in user context (via usb etc.), this implies that we could
scan while not in user context.
I don't see how that would work, since the scan sleeps waiting for IO.
Do we really call scan_scsis and scsi_build_commandblocks while not in user
context? Who is the caller (to scsi_register_host)?
Here is Pete's response saying he found such a case, but not where:
http://marc.theaimsgroup.com/?l=linux-scsi&m=101678634608966&w=2
-- Patrick Mansfield
next prev parent reply other threads:[~2002-08-30 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 0:25 GFP_ATOMIC allocations Doug Ledford
2002-08-29 0:47 ` Patrick Mansfield
2002-08-29 1:42 ` Doug Ledford
2002-08-29 10:47 ` Alan Cox
2002-08-29 15:58 ` Doug Ledford
2002-08-29 17:10 ` Patrick Mansfield
2002-08-30 16:22 ` Patrick Mansfield [this message]
2002-08-30 16:46 ` James Bottomley
2002-08-30 18:58 ` Doug Ledford
2002-08-30 21:55 ` [PATCH] " Patrick Mansfield
2002-09-03 14:57 ` James Bottomley
2002-09-03 16:07 ` Pete Zaitcev
-- strict thread matches above, loose matches on Subject: below --
2002-08-29 15:59 Bryan Henderson
2002-08-29 16:25 ` Doug Ledford
2002-08-29 16:50 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020830092257.A19730@eng2.beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox