Re: [PATCH] 2.5.31 scsi_error.c cleanup

Mike Anderson
2002-08-22T20:10:48Z

James Bottomley [James.Bottomley@SteelEye.com] wrote:
> Ah, OK. I missed that in the logic flow. Does it perhaps make sense to move
> the offline into its own nicely named function? It might add to the initial
> readability of scsi_unjam_host. I see it was problematic because the offline
> loop is bound up inside the host loop.
>
> James

On early versions of the patch I had off-lining in its own function, but
moved it into scsi_eh_bus_host_reset for some forgotten reason. I will
re-roll the patch with a offline function as I agree it will improve the
readability of scsi_unjam_host.

-Mike

--
Michael Anderson
andmike@us.ibm.com