Re: PATCH: scsi device queue depth adjustability patch

James Bottomley
2002-10-03T14:25:48Z

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

dledford@redhat.com said:
> What I need, people to test this with the old aic7xxx driver (which
> implements the new code paths, no other drivers do) and people to test
> with other drivers to make sure it doesn't break them. If I don't
> hear complaints then I'll move on to my next change which is far more
> intrusive on drivers in general.

After fixing up the 53c700 to use the new adjust queue depths stuff, I can
confirm it's working fine for me here (well, actually I fixed the generic scsi
tcq code to use it, but only the 53c700 driver uses this).

James

[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 641 bytes --]

===== scsi.h 1.22 vs edited =====
--- 1.22/drivers/scsi/scsi.h Thu Aug 15 16:01:28 2002
+++ edited/scsi.h Thu Aug 15 16:18:53 2002
@@ -882,7 +882,7 @@

if(SDpnt->tagged_supported && !blk_queue_tagged(q)) {
blk_queue_init_tags(q, depth);
- SDpnt->tagged_queue = 1;
+ scsi_adjust_queue_depth(SDpnt, 1, depth);
}
}

@@ -892,7 +892,7 @@
**/
static inline void scsi_deactivate_tcq(Scsi_Device *SDpnt) {
blk_queue_free_tags(&SDpnt->request_queue);
- SDpnt->tagged_queue = 0;
+ scsi_adjust_queue_depth(SDpnt, 0, 2);
}
#define MSG_SIMPLE_TAG 0x20
#define MSG_HEAD_TAG 0x21