Re: [PATCH] 2.5.31 scsi_error.c cleanup

Mike Anderson
2002-08-22T16:34:39Z

James Bottomley [James.Bottomley@steeleye.com] wrote:
> andmike@us.ibm.com said:
> > I did not change any of the current error policy. I would like to do
> > that in the future.
>
> Looking through the patch, it seems you've changed the offline behavior. Now
> if all error recovery fails, the machine will panic instead of just offlining
> the failed device. I know offlining has never worked correctly, because it
> always seems to leave the system hanging, but it is a useful feature for large
> machines with many SCSI attachments, could you look at trying to get it to
> work corectly?
>
> Thanks,
>
> James

Thanks for the feedback my intent was not to panic on failed recovery. I
will re-verify an offline case.

All sdev's that fail to recover in scsi_eh_bus_host_reset through a bus
and/or host reset should be offlined at the bottom of the channel for
loop before we go on to the next channel. The BUG_ON(shost->host_failed)
in scsi_unjam host is a carryover from the old scsi_error panic that I
believe was trying to catch race conditions / code problems. I left the
check in for now.

-Mike

--
Michael Anderson
andmike@us.ibm.com