Re: [PATCH 2/4] 2.4 SCSI error handling fixes

[Russell King <rmk@arm.linux.org.uk>]

On Thu, Sep 12, 2002 at 02:18:06PM -0400, Doug Ledford wrote:
> On Thu, Sep 12, 2002 at 07:13:54PM +0100, Russell King wrote:
> > -	scsi_setup_cmd_retry(SCpnt);
> > -	scsi_send_eh_cmnd(SCpnt, SCpnt->timeout_per_command);
> > +	do {
> > +		scsi_setup_cmd_retry(SCpnt);
> > +		scsi_send_eh_cmnd(SCpnt, SCpnt->timeout_per_command);
> > +	} while (SCpnt->eh_state == NEEDS_RETRY);
> 
> > +		 * If the SCSI device responded with "logical unit
> > +		 * is in process of becoming ready", we need to
> > +		 * retry this command.
> > +		 */
> > +	} while (SCpnt->eh_state == NEEDS_RETRY);
> 
> > +		/*
> > +		 * If the SCSI device responded with "logical unit
> > +		 * is in process of becoming ready", we need to
> > +		 * retry this command.
> > +		 */
> > +	} while (SCpnt->eh_state == NEEDS_RETRY);
> 
> >  		default:
> > -			SCpnt->eh_state = FAILED;
> > +			ret = FAILED;
> > +			/*FALLTHROUGH*/
> > +		case FAILED:
> > +		case NEEDS_RETRY:
> > +		case SUCCESS:
> > +			SCpnt->eh_state = ret;
> >  			break;
> >  		}
> >  	} else {
> 
> I don't see any bounding here.  You *have* to bound this.  It is not that 
> uncommon for a device to report "logical unit is in the process of 
> becoming ready" forever on certain types of hardware failures.  Without 
> bounding, we won't ever give up on it.

Shrug.  I've not changed the behaviour here.  I've just fixed the ONE
problem where we reissue the command back to the HBA driver with stale
state information.  I never claimed that it fixed ALL bugs.

I'm afraid that I'm going to have to leave the other bugs are for
someone else to address; I've already spent too long on this issue.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html