From: Patrick Mansfield <patmans@us.ibm.com>
To: Russell King <rmk@arm.linux.org.uk>, Kai.Makisara@metla.fi
Cc: linux-scsi@vger.kernel.org
Subject: Re: 2.4.19 SCSI error handing, door locking, etc
Date: Fri, 4 Oct 2002 14:32:17 -0700 [thread overview]
Message-ID: <20021004143217.A18636@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <20021004204925.D31015@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Fri, Oct 04, 2002 at 08:49:25PM +0100
Hi -
I noticed that the tape drivers (st.c and osst.c) are not using the
scsi_ioctl() for door locking, so they won't ever set the new
Scsi_Device::locked.
There is some auto-relock code, but AFAICT (at least st.c, searching for
MTLOCK) it will only relock after a reset (if was_reset is still set),
and we are calling st_ioctl() for one of these MT commands:
MTREW MTOFFL MTRETEN MTERASE MTSEEK MTEOM
The user can't even relock the door unless one of the above commands
was sent (again, if was_reset is still set).
The auto-relock in rw_checks() is never hit if was_reset is set.
Kai - should st.c (and osst.c?) be using scsi_ioctl(SCSI_IOCTL_DOORLOCK/UNLOCK)?
-- Patrick Mansfield
next prev parent reply other threads:[~2002-10-04 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 0:23 2.4.19 SCSI error handing, door locking, etc Russell King
2002-10-04 19:41 ` Mike Anderson
2002-10-04 19:49 ` Russell King
2002-10-04 21:32 ` Patrick Mansfield [this message]
2002-10-05 7:54 ` Kai Makisara
2002-10-13 15:59 ` Willem Riede
2002-10-05 7:23 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021004143217.A18636@eng2.beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=Kai.Makisara@metla.fi \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox