Re: [PATCH] fix 2.5 scsi queue depth setting

J.E.J. Bottomley
2002-11-06T18:50:04Z

patmans@us.ibm.com said:
> That is what we had before, but then there is no warning that the
> queue depth is at 1, and the only way to make sure it is right is to
> audit the drivers.

I'm OK with that, since the drivers can be audited as they're moved over to
slave attach. It also works for drivers that use older hardware (like the
53c700) which don't call adjust_queue_depth from slave attach, but slightly
later on when they've really verified the device will accept tags. In this
case, I don't want the mid layer to call adjust_queue_depth for me even if I
leave slave_attach with only one command allocated.

The bottom line is that if a driver supplies a slave_attach routine, tag setup
is entirely under its control and the mid-layer won't try to second guess it
if it doesn't set them up correctly.

James