Re: [PATCH] 2.5.31 scsi_error.c cleanup

James Bottomley
2002-08-22T17:11:17Z

andmike@us.ibm.com said:
> Thanks for the feedback my intent was not to panic on failed recovery.
> I will re-verify an offline case.

> All sdev's that fail to recover in scsi_eh_bus_host_reset through a
> bus and/or host reset should be offlined at the bottom of the channel
> for loop before we go on to the next channel. The BUG_ON(shost->
> host_failed) in scsi_unjam host is a carryover from the old scsi_error
> panic that I believe was trying to catch race conditions / code
> problems. I left the check in for now.

Ah, OK. I missed that in the logic flow. Does it perhaps make sense to move
the offline into its own nicely named function? It might add to the initial
readability of scsi_unjam_host. I see it was problematic because the offline
loop is bound up inside the host loop.

James