Re: [PATCH] get rid of ->finish method for highlevel drivers

Patrick Mansfield
2002-10-22T18:43:54Z

On Tue, Oct 22, 2002 at 10:48:19AM -0500, James Bottomley wrote:
>
> I tracked down the essential problem: the CD rom finish method expects to have
> allocated command blocks to do a mode sense. I also fixed a trivial
> initialisation problem (the device pointer in Scsi_CD was being used before it
> was initialised).
>
> The attached patch fixes the problem for me.
>
> I still can't detach and add a CD-ROM, but the panic is in sr_init, so doesn't
> look to be affected by these changes, but I'll continue debugging.
>
> James
>

James -

How do we end up with no command blocks if the slave_attach is
calling scsi_build_commandblocks via scsi_adjust_queue_depth?

-- Patrick Mansfield