Re: [PATCH] first cut at fixing unable to requeue with no outstanding commands

James Bottomley
2002-10-01T16:31:04Z

andmike@us.ibm.com said:
> - Is the call to scsi_delete_timer really necessary. All callers
> have already deleted the timer. The del_timer function takes a
> lock which would be nice to avoid if we do not need to call
> it. If we want to protect the code we could do a quick check
> on SCset->eh_timeout.function prior to calling.

That's a belt and braces thing. I suppose we could change it to BUG_ON timer
active and see what pops out of the woodwork.

andmike@us.ibm.com said:
> - Patrick pointed out a while ago that the "if (host->host_busy
> == 0)" check and the similar one for the device will never be
> called because to be in this function the values of these
> variables need to be at least 1. I believe this direct call to
> scsi_retry_command should be removed instead of adjusting the
> check to "== 1" as this seems counter to how you are trying to
> handle busy.

Yes, I plan on slowly removing all automatic reissues of commands. I've
already removed the checks in my local tree (and the corresponding reissues).

James