Re: SCSI woes (followup)

Russell King
2002-09-24T19:21:21Z

On Tue, Sep 24, 2002 at 12:08:09PM -0700, Mike Anderson wrote:
> Patrick Mansfield [patmans@us.ibm.com] wrote:
> > The problem is that we try to send a command via scsi_request_fn() to
> > a device that has no command blocks allocated - it's initializatin
> > is incomplete.
> >
> > Moving the empty check up sounds like good and simple fix for 2.4, or
> > check if queue_depth == 0. Anything else would be difficult to get right.
>
> Since error handling running during scan is kinda casuing the problem a
> a patch like the one below to scsi_restart_operations sould also work.

No. There are still deadlock cases. This is the _wrong_ fix.

Been there. Tried it. It failed.

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux