Re: [patch 2.5] ips queue depths

Dave Hansen
2002-10-15T19:30:45Z

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Jeffery, David wrote:
> Dave,
>
> Here's a patch that should restore the queue depths to what they were before
> the
> queue depths change was merged in. Hopefully this well restore your lost
> performance. If I don't hear or find anything bad about it, it will be
> going
> to Linus shortly.
>
> And thanks goes to Mike Anderson for his initial version. That made writing
> this patch all the easier.

Thank you for taking care of that so quickly. I've tested it and it
shows that I'm within 0.5% of where I was before. this is well within
the margin of error for my test.

On another (completely cosmetic) note, ips.c is spitting out warnings
because of the IPS_*LOCK_RESTORE macros which don't use the flags
argument in 2.5. If you're sending an update to Linus, could you
include something like what I've attached to get rid of them?
--
Dave Hansen
haveblue@us.ibm.com

[-- Attachment #2: ips-warning-fix-2.5.42+bk-0.patch --]
[-- Type: text/plain, Size: 633 bytes --]

--- ips.c.orig Tue Oct 15 12:24:25 2002
+++ ips.c Tue Oct 15 12:25:24 2002
@@ -248,8 +248,8 @@
#else
#define IPS_SG_ADDRESS(sg) (page_address((sg)->page) ? \
page_address((sg)->page)+(sg)->offset : 0)
- #define IPS_LOCK_SAVE(lock,flags) spin_lock(lock)
- #define IPS_UNLOCK_RESTORE(lock,flags) spin_unlock(lock)
+ #define IPS_LOCK_SAVE(lock,flags) do { spin_lock(lock); (void)flags } while (0)
+ #define IPS_UNLOCK_RESTORE(lock,flags) { spin_unlock(lock); (void)flags } while (0)
#endif

#define IPS_DMA_DIR(scb) ((!scb->scsi_cmd || ips_is_passthru(scb->scsi_cmd) || \