From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@steeleye.com>,
axboe@suse.dk, linux-scsi@vger.kernel.org
Subject: Re: [PATCH][RFC] get rid of global array and ->init in sd.c and sr.c
Date: Thu, 24 Oct 2002 02:50:30 +0200 [thread overview]
Message-ID: <20021024025030.A20656@lst.de> (raw)
In-Reply-To: <20021023171729.GA1048@beaverton.ibm.com>; from andmike@us.ibm.com on Wed, Oct 23, 2002 at 10:17:29AM -0700
On Wed, Oct 23, 2002 at 10:17:29AM -0700, Mike Anderson wrote:
> ok. Sorry I did not comment on that previous device model cleanup. I do
> have a couple comments now though.
>
> In scsi_register_device (which we should probably rename to
> scsi_bus_register_driver) we could just call
> driver_register(&tpnt->scsi_driverfs_driver).
>
> In the upper levels just do something like this:
>
> .
> .
> .
> .init_command = sd_init_command,
> .scsi_driverfs_driver {
> .name = "sd",
> .bus = &scsi_driverfs_bus_type,
> .probe = sd_probe,
> .remove = sd_remove, },
>
> We can also remove .tag from the template.
>
>
> This gives more flexibility to the upper levels in-case they need to add
> to there driver template.
Looks fine to me. I'll do that once the driverfs/sysfs changes
settle down a bit.
prev parent reply other threads:[~2002-10-24 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 19:07 [PATCH][RFC] get rid of global array and ->init in sd.c and sr.c Christoph Hellwig
2002-10-23 8:28 ` Mike Anderson
2002-10-23 15:11 ` Christoph Hellwig
2002-10-23 17:17 ` Mike Anderson
2002-10-24 0:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021024025030.A20656@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.dk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).