linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: dougg@torque.net
Cc: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] merge sd.h into sd.c and some cleanup
Date: Sun, 27 Oct 2002 08:25:29 -0600	[thread overview]
Message-ID: <200210271425.g9REPTn10749@localhost.localdomain> (raw)
In-Reply-To: Message from Douglas Gilbert <dougg@torque.net> of "Sun, 27 Oct 2002 22:22:03 +1100." <3DBBCC5B.50708@torque.net>

dougg@torque.net said:
> The header file "sd.h" is included in quite a few lower level drivers
> in lk 2.5.44 (at least 55) and perhaps in a couple of other
> subsystems. The reason it is included is for the "biosparam" call in
> the API of lower level drivers. Whether it is still used or useful,
> I'm not sure. [It does seem quite unreasonable that lower level
> drivers need to include an upper level header.]

There was a previous patch that cleaned all that up.  I'm just completing 
testing on this before putting it up.

> You can drop my credit line (shown above) from sd.c . Perhaps James
> could make a "credits" file for everyone who has helped in the 2.5
> scsi rework. 

Credits are a double edged sword (If you look, you'll find there's very little 
of the SCSI subsystem I actually admit to).  I've just been adding them if 
people included them in their patches.  Some do, some don't.  If you want 
yours dropped, send me a patch that drops it.

James



  reply	other threads:[~2002-10-27 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-26  1:18 [PATCH] merge sd.h into sd.c and some cleanup Christoph Hellwig
2002-10-27 11:22 ` Douglas Gilbert
2002-10-27 14:25   ` James Bottomley [this message]
2002-10-27 14:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210271425.g9REPTn10749@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=dougg@torque.net \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).