From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix sector_div use in scsicam.c
Date: Sun, 27 Oct 2002 10:34:09 -0600 [thread overview]
Message-ID: <200210271634.g9RGYAY11441@localhost.localdomain> (raw)
In-Reply-To: Message from Christoph Hellwig <hch@lst.de> of "Sun, 27 Oct 2002 17:23:07 +0100." <20021027172307.A15930@lst.de>
> - ip[2] = sector_div(capacity, ip[0] * ip[1]);
> + sector_div(capacity, ip[0] * ip[1]);
> + ip[2] = capacity;
Now you've lost your optimisation. The second sector_div should be inside the
if.
James
next prev parent reply other threads:[~2002-10-27 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-27 16:02 [PATCH] fix sector_div use in scsicam.c Christoph Hellwig
2002-10-27 16:21 ` James Bottomley
2002-10-27 16:23 ` Christoph Hellwig
2002-10-27 16:34 ` James Bottomley [this message]
2002-10-27 16:37 ` Christoph Hellwig
2002-10-27 19:22 ` Andries Brouwer
2002-10-27 20:53 ` James Bottomley
2002-10-27 22:10 ` Andries Brouwer
2002-10-28 0:05 ` James Bottomley
2002-10-28 0:50 ` Andries Brouwer
2002-10-28 1:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210271634.g9RGYAY11441@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).