From: Christoph Hellwig <hch@infradead.org>
To: linux-scsi@vger.kernel.org
Subject: [hch@infradead.org: Re: [PATCH] fix 2.5 scsi queue depth setting]
Date: Wed, 6 Nov 2002 21:05:42 +0000 [thread overview]
Message-ID: <20021106210542.A32241@infradead.org> (raw)
Urgg, removed abit to much than just me from the cc line..
----- Forwarded message from Christoph Hellwig <hch@infradead.org> -----
Date: Wed, 6 Nov 2002 21:01:13 +0000
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] fix 2.5 scsi queue depth setting
To: Patrick Mansfield <patmans@us.ibm.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
inux-scsi@vger.kernel.org
On Wed, Nov 06, 2002 at 03:50:50PM -0500, Doug Ledford wrote:
> if(sdev->hostdata)
> kfree(sdev->hostdata);
kfree(NULL) is fine, btw..
> sdev->hostdata = NULL;
>
> after the slave_detach call. The other option is to slightly refine the
> slave_attach/slave_detach API to specificy that if your attach routine
> allocates and hangs memory off of sdev->hostdata, then you *must*
> implement a slave_detach() routine and you must free said memory yourself
> (and NULL out the pointer to be safe).
I'm all for the second option, but I don't think we should specify the
NULLing out, the device will go away anyway.
----- End forwarded message -----
next reply other threads:[~2002-11-06 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-06 21:05 Christoph Hellwig [this message]
2002-11-06 21:20 ` [hch@infradead.org: Re: [PATCH] fix 2.5 scsi queue depth setting] Doug Ledford
2002-11-07 2:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021106210542.A32241@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox