public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@sgi.com>
To: Mike Anderson <andmike@us.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi sysfs update (upper 2/3)
Date: Thu, 7 Nov 2002 18:29:47 -0500	[thread overview]
Message-ID: <20021107182947.B15350@sgi.com> (raw)
In-Reply-To: <20021107073943.GB1390@beaverton.ibm.com>; from andmike@us.ibm.com on Wed, Nov 06, 2002 at 11:39:43PM -0800

On Wed, Nov 06, 2002 at 11:39:43PM -0800, Mike Anderson wrote:
> +	.scsi_driverfs_driver   = {
> +		.name   = "sd",
> +	},

can we changhe scsi_driverfs_driver to something saner? E.g. gen_driver?

>  static struct scsi_disk *sd_find_by_sdev(Scsi_Device *sd)
> @@ -1346,7 +1349,7 @@
>  	if (!majors)
>  		return -ENODEV;
>  
> -	rc = scsi_register_device(&sd_template);
> +	rc = scsi_bus_driver_register(&sd_template);

Umm, no.  We don't register a bus.  Just leave the name unchanged until
we there is some commonly agreed upon upper layer terminology.

  parent reply	other threads:[~2002-11-07 23:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-07  7:36 [PATCH] scsi sysfs update (base 1/3) Mike Anderson
2002-11-07  7:39 ` [PATCH] scsi sysfs update (upper 2/3) Mike Anderson
2002-11-07  7:42   ` [PATCH] scsi sysfs update (scsi_debug 3/3) Mike Anderson
2002-11-07 23:30     ` Christoph Hellwig
2002-11-07 16:33       ` Mike Anderson
2002-11-07 23:35         ` Douglas Gilbert
2002-11-08  2:30           ` Christoph Hellwig
2002-11-07 23:29   ` Christoph Hellwig [this message]
2002-11-07 16:41     ` [PATCH] scsi sysfs update (upper 2/3) Mike Anderson
2002-11-08  1:20       ` Christoph Hellwig
2002-11-08  2:21         ` Mike Anderson
2002-11-08  3:34           ` Douglas Gilbert
2002-11-08  4:13             ` Mike Anderson
2002-11-08  4:53           ` Christoph Hellwig
2002-11-08  5:41             ` Mike Anderson
2002-11-07 23:28 ` [PATCH] scsi sysfs update (base 1/3) Christoph Hellwig
2002-11-07 17:01   ` Mike Anderson
2002-11-07 17:22     ` Patrick Mansfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021107182947.B15350@sgi.com \
    --to=hch@sgi.com \
    --cc=andmike@us.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox