* Re: Linux v2.5.47 [not found] <Pine.LNX.4.44.0211101944030.17742-100000@penguin.transmeta.com> @ 2002-11-13 0:22 ` Christoph Hellwig 2002-11-13 1:03 ` Alan Cox 2002-11-13 12:03 ` Michael Still 0 siblings, 2 replies; 4+ messages in thread From: Christoph Hellwig @ 2002-11-13 0:22 UTC (permalink / raw) To: Linus Torvalds; +Cc: Kernel Mailing List, linux-scsi On Sun, Nov 10, 2002 at 07:46:06PM -0800, Linus Torvalds wrote: > > I still have stuff pending, but this is what's currently merged. Btw, here's a little headsup for all maintainers of scsi host adapter drivers. In 2.5.47 the detect and release methods of the Scsi_Host_Template have become optional. If you had an old pci driver with the following loop in foo_detcect: while ((pdev = pci_find_device())) { [do basic setup] sdev = scsi_register(); [do more setup] } You can convert it easily into a new-style pci driver with the following probe routine: [do basic setup] sdev = scsi_register(); [do more setup] return scsi_add_host(); Similarly a new routine, scsi_remove_host exist to call at the end of the remove routine. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux v2.5.47 2002-11-13 0:22 ` Linux v2.5.47 Christoph Hellwig @ 2002-11-13 1:03 ` Alan Cox 2002-11-13 0:43 ` Christoph Hellwig 2002-11-13 12:03 ` Michael Still 1 sibling, 1 reply; 4+ messages in thread From: Alan Cox @ 2002-11-13 1:03 UTC (permalink / raw) To: Christoph Hellwig; +Cc: Linus Torvalds, Linux Kernel Mailing List, linux-scsi On Wed, 2002-11-13 at 00:22, Christoph Hellwig wrote: > [do basic setup] > sdev = scsi_register(); > [do more setup] > return scsi_add_host(); > > Similarly a new routine, scsi_remove_host exist to call at the end > of the remove routine. Very very nice. One question - what are the rules for the scsi_remove_host callback with regards to a hotplug ? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux v2.5.47 2002-11-13 1:03 ` Alan Cox @ 2002-11-13 0:43 ` Christoph Hellwig 0 siblings, 0 replies; 4+ messages in thread From: Christoph Hellwig @ 2002-11-13 0:43 UTC (permalink / raw) To: Alan Cox; +Cc: Linus Torvalds, Linux Kernel Mailing List, linux-scsi On Wed, Nov 13, 2002 at 01:03:52AM +0000, Alan Cox wrote: > Very very nice. One question - what are the rules for the > scsi_remove_host callback with regards to a hotplug ? The general rule so far is: don't do hotplug - scsi code, especially list handling, is racy as hell. I'm not sure whether we'll have it properly locked down and refcounted by 2.6, it's a lot of work left. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux v2.5.47 2002-11-13 0:22 ` Linux v2.5.47 Christoph Hellwig 2002-11-13 1:03 ` Alan Cox @ 2002-11-13 12:03 ` Michael Still 1 sibling, 0 replies; 4+ messages in thread From: Michael Still @ 2002-11-13 12:03 UTC (permalink / raw) To: Christoph Hellwig; +Cc: Kernel Mailing List, linux-scsi On Wed, 13 Nov 2002, Christoph Hellwig wrote: > You can convert it easily into a new-style pci driver with the following > probe routine: Remembering of course that a scsi_register() can fail... > [do basic setup] > sdev = scsi_register(); if(sdev == NULL){ /* Handle error */ } > [do more setup] > return scsi_add_host(); Cheers, Mikal -- Michael Still (mikal@stillhq.com) UTC +10 hours ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-11-13 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.44.0211101944030.17742-100000@penguin.transmeta.com>
2002-11-13 0:22 ` Linux v2.5.47 Christoph Hellwig
2002-11-13 1:03 ` Alan Cox
2002-11-13 0:43 ` Christoph Hellwig
2002-11-13 12:03 ` Michael Still
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox