Re: Linux v2.5.47

Re: Linux v2.5.47

[Christoph Hellwig]

On Sun, Nov 10, 2002 at 07:46:06PM -0800, Linus Torvalds wrote:
> 
> I still have stuff pending, but this is what's currently merged. 

Btw, here's a little headsup for all maintainers of scsi host adapter
drivers.  In 2.5.47 the detect and release methods of the Scsi_Host_Template
have become optional.  If you had an old pci driver with the following
loop in foo_detcect:

	while ((pdev = pci_find_device())) {
		[do basic setup]
		sdev = scsi_register();
		[do more setup]
	}

You can convert it easily into a new-style pci driver with the following
probe routine:

	[do basic setup]
	sdev = scsi_register();
	[do more setup]
	return scsi_add_host();

Similarly a new routine, scsi_remove_host exist to call at the end
of the remove routine.

Re: Linux v2.5.47

[Alan Cox]

On Wed, 2002-11-13 at 00:22, Christoph Hellwig wrote:
> 	[do basic setup]
> 	sdev = scsi_register();
> 	[do more setup]
> 	return scsi_add_host();
> 
> Similarly a new routine, scsi_remove_host exist to call at the end
> of the remove routine.

Very very nice. One question - what are the rules for the
scsi_remove_host callback with regards to a hotplug ? 

Re: Linux v2.5.47

[Christoph Hellwig]

On Wed, Nov 13, 2002 at 01:03:52AM +0000, Alan Cox wrote:
> Very very nice. One question - what are the rules for the
> scsi_remove_host callback with regards to a hotplug ? 

The general rule so far is:  don't do hotplug - scsi code, especially
list handling, is racy as hell.  I'm not sure whether we'll have it
properly locked down and refcounted by 2.6, it's a lot of work left.

Re: Linux v2.5.47

[Michael Still]

On Wed, 13 Nov 2002, Christoph Hellwig wrote:

> You can convert it easily into a new-style pci driver with the following
> probe routine:

Remembering of course that a scsi_register() can fail...

> 	[do basic setup]
> 	sdev = scsi_register();

        if(sdev == NULL){
          /* Handle error */
          }

> 	[do more setup]
> 	return scsi_add_host();

Cheers,
Mikal

-- 

Michael Still (mikal@stillhq.com)     UTC +10 hours