From: Patrick Mansfield <patmans@us.ibm.com>
To: Douglas Gilbert <dougg@torque.net>,
"J. E. J. Bottomley" <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: 2.5.48 /proc/scsi directory missing
Date: Mon, 18 Nov 2002 17:14:46 -0800 [thread overview]
Message-ID: <20021118171446.A28459@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <3DD97B95.9040908@torque.net>; from dougg@torque.net on Tue, Nov 19, 2002 at 10:45:25AM +1100
On Tue, Nov 19, 2002 at 10:45:25AM +1100, Douglas Gilbert wrote:
> That directory (and all who sail in her, e.g. /proc/scsi/scsi)
> seems to have disappeared. When the scsi_debug module is
> loaded a /proc/scsi_debug/0 entry appears (that used to be
> /proc/scsi/scsi_debug/0).
>
> Doug Gilbert
It looks like the merge of Doug and Christoph's code dropped two calls
(unless the exit devfs_unregister was supposed to be removed).
Here's a patch for the addition of scsi_init_procfs, devfs_mk_dir and
bus_unregister calls, and a small reordering so calls in exit_scsi
match the reverse of those in init_scsi.
--- 1.67/drivers/scsi/scsi.c Mon Nov 18 08:42:42 2002
+++ edited/scsi.c Mon Nov 18 16:14:23 2002
@@ -2225,6 +2225,8 @@
printk(KERN_ERR "SCSI: can't init sg mempool %s\n", sgp->name);
}
+ scsi_init_procfs();
+ scsi_devfs_handle = devfs_mk_dir(NULL, "scsi", NULL);
scsi_host_init();
scsi_dev_info_list_init(scsi_dev_flags);
bus_register(&scsi_driverfs_bus_type);
@@ -2236,9 +2238,10 @@
{
int i;
+ bus_unregister(&scsi_driverfs_bus_type);
+ scsi_dev_info_list_delete();
devfs_unregister(scsi_devfs_handle);
scsi_exit_procfs();
- scsi_dev_info_list_delete();
for (i = 0; i < SG_MEMPOOL_NR; i++) {
struct scsi_host_sg_pool *sgp = scsi_sg_pools + i;
next prev parent reply other threads:[~2002-11-19 1:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 23:45 2.5.48 /proc/scsi directory missing Douglas Gilbert
2002-11-19 1:14 ` Patrick Mansfield [this message]
2002-11-19 6:16 ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 6:28 ` linux-2.4.18-modified-scsi-h.patch Jeff Garzik
2002-11-19 6:42 ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 10:11 ` linux-2.4.18-modified-scsi-h.patch Douglas Gilbert
2002-11-19 12:16 ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 18:40 ` linux-2.4.18-modified-scsi-h.patch Patrick Mansfield
2002-11-19 18:48 ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 18:47 ` linux-2.4.18-modified-scsi-h.patch Jeff Garzik
2002-11-19 18:50 ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021118171446.A28459@eng2.beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox