* [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h
@ 2002-12-05 22:16 Patrick Mansfield
2002-12-05 22:26 ` James Bottomley
0 siblings, 1 reply; 4+ messages in thread
From: Patrick Mansfield @ 2002-12-05 22:16 UTC (permalink / raw)
To: JEJ Bottomley; +Cc: Christoph Hellwig, linux-scsi
The current scsi-misc-2.5 scsi_lib.c needs to include init.h
to get the __init and __exit defined.
--- 1.57/drivers/scsi/scsi_lib.c Thu Dec 5 11:59:51 2002
+++ edited/drivers/scsi/scsi_lib.c Thu Dec 5 13:11:35 2002
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/mempool.h>
#include <linux/slab.h>
+#include <linux/init.h>
#include "scsi.h"
#include "hosts.h"
-- Patrick Mansfield
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h
2002-12-05 22:16 [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h Patrick Mansfield
@ 2002-12-05 22:26 ` James Bottomley
2002-12-05 22:54 ` Patrick Mansfield
0 siblings, 1 reply; 4+ messages in thread
From: James Bottomley @ 2002-12-05 22:26 UTC (permalink / raw)
To: Patrick Mansfield; +Cc: JEJ Bottomley, Christoph Hellwig, linux-scsi
patmans@us.ibm.com said:
> he current scsi-misc-2.5 scsi_lib.c needs to include init.h to get the
> __init and __exit defined.
not for me here. init.h seems to be pulled in via a long chain:
from include/linux/profile.h:8,
from include/asm/hw_irq.h:16,
from include/linux/irq.h:69,
from include/asm/hardirq.h:6,
from include/linux/interrupt.h:9,
from include/asm/highmem.h:24,
from include/linux/highmem.h:12,
from include/linux/bio.h:24,
from drivers/scsi/scsi_lib.c:10:
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h
2002-12-05 22:26 ` James Bottomley
@ 2002-12-05 22:54 ` Patrick Mansfield
2002-12-05 22:58 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Patrick Mansfield @ 2002-12-05 22:54 UTC (permalink / raw)
To: James Bottomley; +Cc: Christoph Hellwig, linux-scsi
On Thu, Dec 05, 2002 at 04:26:45PM -0600, James Bottomley wrote:
> patmans@us.ibm.com said:
> > he current scsi-misc-2.5 scsi_lib.c needs to include init.h to get the
> > __init and __exit defined.
>
> not for me here. init.h seems to be pulled in via a long chain:
>
> from include/linux/profile.h:8,
> from include/asm/hw_irq.h:16,
> from include/linux/irq.h:69,
> from include/asm/hardirq.h:6,
> from include/linux/interrupt.h:9,
> from include/asm/highmem.h:24,
> from include/linux/highmem.h:12,
> from include/linux/bio.h:24,
> from drivers/scsi/scsi_lib.c:10:
>
> James
James -
It looks like CONFIG_HIGHEM changes that behaviour, my .config has:
CONFIG_NOHIGHMEM=y
# CONFIG_HIGHMEM4G is not set
# CONFIG_HIGHMEM64G is not set
highmem.h does not include asm/highmem.h unless #ifdef CONFIG_HIGHMEM.
I changed my config to use highmem 4g, and it compiled OK.
-- Patrick Mansfield
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h
2002-12-05 22:54 ` Patrick Mansfield
@ 2002-12-05 22:58 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2002-12-05 22:58 UTC (permalink / raw)
To: Patrick Mansfield; +Cc: James Bottomley, Christoph Hellwig, linux-scsi
On Thu, Dec 05, 2002 at 02:54:41PM -0800, Patrick Mansfield wrote:
> highmem.h does not include asm/highmem.h unless #ifdef CONFIG_HIGHMEM.
>
> I changed my config to use highmem 4g, and it compiled OK.
Sorry for the breakage. I'll do a sweep over all asm headers to get rid of
implicit inclusions of init.h (unless impossible, but I dount it)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-12-05 22:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-05 22:16 [PATCH] current scsi-misc-2.5 scsi_lib.c needs init.h Patrick Mansfield
2002-12-05 22:26 ` James Bottomley
2002-12-05 22:54 ` Patrick Mansfield
2002-12-05 22:58 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox