From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: Aic7xxx v6.2.22 and Aic79xx v1.3.0Alpha2 Released Date: Fri, 13 Dec 2002 16:23:52 -0500 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20021213212352.GA10883@redhat.com> References: <200212101602.gBAG2Hi02930@localhost.localdomain> <20021211135855.A19325@infradead.org> <1266570000.1039619906@aslan.scsiguy.com> <20021211153935.A23704@infradead.org> <1221760000.1039627865@aslan.btc.adaptec.com> <20021211181745.A30253@infradead.org> <20021212202052.GC8842@redhat.com> <20021213210215.A15074@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20021213210215.A15074@infradead.org> List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig Cc: linux-scsi@vger.kernel.org On Fri, Dec 13, 2002 at 09:02:15PM +0000, Christoph Hellwig wrote: > On Thu, Dec 12, 2002 at 03:20:52PM -0500, Doug Ledford wrote: > > On Wed, Dec 11, 2002 at 06:17:46PM +0000, Christoph Hellwig wrote: > > > > > > Yupp, it currently crashes when I have both compiled in. Dough, any chance > > > you could fix that? A PCI driver is not supposed to stop over already > > > claimed device. > > > > If you've got a test machine, the attached patch would I think fix the > > problem. Let me know if it does in fact work for you and I'll commit it > > to the tree. > > Still doesn't work. I think you really need to set and check the driver > field like justin suggested. Hmmm...what's the failure mode here? And if it doesn't work this way, then how's it ever suppossed to work on the non-PCI controllers both of our modules support since last I knew, you never get called by the pci hot plug core on non-PCI controllers so the lockout method between our drivers can *not* be pci specific and still work in all cases. The request_region stuff always was and still is the only truly generic io space protection mechanism that works on all devices on all busses. -- Doug Ledford 919-754-3700 x44233 Red Hat, Inc. 1801 Varsity Dr. Raleigh, NC 27606