From: Willem Riede <wrlk@riede.org>
To: dgilbert@interlog.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: buggy scsi_register behaviour in 2.5.51
Date: Tue, 17 Dec 2002 20:52:33 -0500 [thread overview]
Message-ID: <20021218015233.GM7990@linnie.riede.org> (raw)
In-Reply-To: <3DFE998E.1080103@interlog.com>; from dgilbert@interlog.com on Mon, Dec 16, 2002 at 22:27:10 -0500
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On 2002.12.16 22:27 Douglas Gilbert wrote:
> Willem,
> Can't fix all those problems but I did notice that
> idescsi_release() was missing a call to scsi_unregister().
> With this patch the ide-scsi entry remains dangling in
> sysfs (ide problem??)
Indeed. There is a call to driver_register in ide_register_driver
but no call to driver_unregister in ide_unregister_driver.
I put one in, and that takes care of it. PATCH to ide.c attached.
Regards, Willem Riede.
[-- Attachment #2: ide.patch --]
[-- Type: text/plain, Size: 279 bytes --]
--- ide.c-l2552 2002-12-09 21:45:52.000000000 -0500
+++ ide.c 2002-12-17 20:43:29.000000000 -0500
@@ -2314,6 +2314,8 @@
{
ide_drive_t *drive;
+ driver_unregister(&driver->gen_driver);
+
spin_lock(&drivers_lock);
list_del(&driver->drivers);
spin_unlock(&drivers_lock);
next prev parent reply other threads:[~2002-12-18 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-17 3:27 buggy scsi_register behaviour in 2.5.51 Douglas Gilbert
2002-12-17 11:47 ` Willem Riede
2002-12-18 12:14 ` Douglas Gilbert
2002-12-18 23:20 ` Willem Riede
2002-12-20 14:46 ` Willem Riede
2002-12-18 1:52 ` Willem Riede [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-17 0:50 Willem Riede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021218015233.GM7990@linnie.riede.org \
--to=wrlk@riede.org \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox