From: Bjorn Helgaas <bjorn_helgaas@hp.com>
To: groudier@free.fr
Cc: linux-scsi@vger.kernel.org, gibbs@scsiguy.com
Subject: sym53c8xx_2 fix
Date: Thu, 19 Dec 2002 13:14:45 -0700 [thread overview]
Message-ID: <200212191314.45778.bjorn_helgaas@hp.com> (raw)
We run the sym53c8xx_2 driver on a simulator. Because the
simulator's disk model is somewhat simplified compared to real
hardware, it exercises some code paths that are not exercised
on the hardware.
Our simulator guru found what appears to be an error in
one such path. Here's his description and patch (against
2.4.20). Let me know if you need more information.
Justin, I copied you because the comment immediately preceding
this code says it's part of an optimization you suggested
(negotiating for SYNC immediately after a WIDE response).
> ... There is also a bug in the driver that keeps us from
> booting. This code path is not executed on hardware but is on the sim with
> our simple disk model. The current driver assembles an SDTR request but
> then calls the SDTR response script. Here is the fix:
> --- orig/linux-ia64-2.4/drivers/scsi/sym53c8xx_2/sym_hipd.c Fri Sep 27 17:27:41 2002
> +++ fixed/linux-ia64-2.4/drivers/scsi/sym53c8xx_2/sym_hipd.c Wed Dec 18 21:26:25 2002
> @@ -4363,7 +4363,7 @@
>
> cp->nego_status = NS_SYNC;
> OUTB (HS_PRT, HS_NEGOTIATE);
> - OUTL_DSP (SCRIPTB_BA (np, sdtr_resp));
> + OUTL_DSP (SCRIPTB_BA (np, send_sdtr));
> return;
> }
--
Bjorn Helgaas - bjorn_helgaas at hp.com
Linux and Open Source Lab
Hewlett-Packard Company
next reply other threads:[~2002-12-19 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-19 20:14 Bjorn Helgaas [this message]
2002-12-23 11:41 ` sym53c8xx_2 fix Gérard Roudier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200212191314.45778.bjorn_helgaas@hp.com \
--to=bjorn_helgaas@hp.com \
--cc=gibbs@scsiguy.com \
--cc=groudier@free.fr \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox