* Re: [PATCH] EDD: fix raw_data file and edd_has_edd30(), misc cleanups
[not found] <Pine.LNX.4.44.0301071728280.3361-100000@humbolt.us.dell.com>
@ 2003-01-08 0:18 ` Mike Anderson
0 siblings, 0 replies; only message in thread
From: Mike Anderson @ 2003-01-08 0:18 UTC (permalink / raw)
To: Matt Domsch; +Cc: linux-kernel, mochel, linux-scsi
Matt Domsch [Matt_Domsch@Dell.com] wrote:
> * use new find_bus() and bus_for_each_dev() to match SCSI devices
.. snip ..
> + struct edd_match_data * data = (struct edd_match_data *)d;
> + struct edd_info *info = edd_dev_get_info(data->edev);
> + struct scsi_device * sd = to_scsi_device(dev);
> +
> + if (info) {
> + if ((sd->channel == info->params.interface_path.pci.channel) &&
> + (sd->id == info->params.device_path.scsi.id) &&
> + (sd->lun == info->params.device_path.scsi.lun)) {
> + data->sd = sd;
> + return 1;
> + }
This change assumes that the scsi sysfs bus only contains struct
scsi_device's. According to sysfs policy we are suppose to have only one
type of struct on this list, but this is not the case currently.
I will work on a patch tonight to remove these extra nodes so that the
st, sg, and osst maintainers can review it.
-andmike
--
Michael Anderson
andmike@us.ibm.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-01-08 0:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.44.0301071728280.3361-100000@humbolt.us.dell.com>
2003-01-08 0:18 ` [PATCH] EDD: fix raw_data file and edd_has_edd30(), misc cleanups Mike Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox