public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Luben Tuikov <luben@splentec.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI Core cmd->host ==> cmd->device->host 2/3
Date: Sat, 11 Jan 2003 17:45:29 +0000	[thread overview]
Message-ID: <20030111174529.A2225@infradead.org> (raw)
In-Reply-To: <3E1A1C78.8050104@splentec.com>; from luben@splentec.com on Mon, Jan 06, 2003 at 07:16:56PM -0500

On Mon, Jan 06, 2003 at 07:16:56PM -0500, Luben Tuikov wrote:
> This patch makes the conversion from scsi cmd->host to
> scsi cmd->device->host for drivers/scsi/*, drivers/usb/storage/*,
> drivers/ieee1394/*, drivers/message/fusion/* .

The patch looks fine in principle.  Two purely cosmetic nitpicks:

1) Please linewrap the now longer lines after 80 lines
2) the cast when assining from ->hostdata are superflous

I know 2) is not your fault, but as you touch it fixing that might make
sense, and usually fixes 1).


  reply	other threads:[~2003-01-11 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-07  0:16 [PATCH] SCSI Core cmd->host ==> cmd->device->host 2/3 Luben Tuikov
2003-01-11 17:45 ` Christoph Hellwig [this message]
2003-01-13 16:46   ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030111174529.A2225@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luben@splentec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox