From: Willem Riede <wrlk@riede.org>
To: Andrew Morton <akpm@digeo.com>
Cc: Paul Rolland <rol@as2917.net>,
linux-kernel@vger.kernel.orgrol@as2917.net,
linux-scsi@vger.kernel.org
Subject: Re: [BUG - 2.5.56] bad: scheduling while atomic
Date: Sat, 11 Jan 2003 13:45:04 -0500 [thread overview]
Message-ID: <20030111184504.GX1378@linnie.riede.org> (raw)
In-Reply-To: <200301110949.48169.akpm@digeo.com>; from akpm@digeo.com on Sat, Jan 11, 2003 at 12:49:48 -0500
On 2003.01.11 12:49 Andrew Morton wrote:
> On Sat January 11 2003 02:40, Paul Rolland wrote:
> >
> > Hello,
> >
> > Trying 2.5.56 this morning, I ended up with the trace included below.
> > To get that, I simply added a
> > "hdd=ide-scsi"
[snip]
> > ide-scsi: abort called for 21
> > bad: scheduling while atomic!
[snip]
> Well this backtrace is not the reason why ide-scsi fails to work - it is
> being triggered as a consequence of the I/O failure.
>
> This trace is due to the following bug:
>
> scsi_try_to_abort_cmd() takes spin_lock_irqsave(scmd->host->host_lock, flags);
> then it calls ide_scsi_abort()
> ide_scsi_abort() calls scsi_sleep(), still inside ->host_lock.
>
That would be my mistake. scmd->host->host_lock doesn't need to be held during
the sleep. I'll come up with a patch.
Thanks, Willem Riede.
prev parent reply other threads:[~2003-01-11 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <003d01c2b95d$e7a6a370$2101a8c0@witbe>
2003-01-11 17:49 ` [BUG - 2.5.56] bad: scheduling while atomic Andrew Morton
2003-01-11 18:45 ` Willem Riede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030111184504.GX1378@linnie.riede.org \
--to=wrlk@riede.org \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.orgrol \
--cc=rol@as2917.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox