From: Patrick Mansfield <patmans@us.ibm.com>
To: Paul Rolland <rol@witbe.net>
Cc: linux-kernel@vger.kernel.org, axboe@suse.de, rol@as2917.net,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2.5.56] Scsi not compiling without /proc support
Date: Mon, 13 Jan 2003 12:16:57 -0800 [thread overview]
Message-ID: <20030113121657.A16667@beaverton.ibm.com> (raw)
In-Reply-To: <009001c2ba32$3b4bcdf0$2101a8c0@witbe>; from rol@witbe.net on Sun, Jan 12, 2003 at 01:00:42PM +0100
On Sun, Jan 12, 2003 at 01:00:42PM +0100, Paul Rolland wrote:
> Hello,
>
> This quick patch is used to remove calls to functions in charge of
> registering/unregistering within /proc when /proc support is not
> enabled.
>
> Paul Rolland, rol@as2917.net
>
> diff -uN linux-2.5.56/drivers/scsi/hosts.c
> linux-2.5.56-work/drivers/scsi/hosts.c
> --- linux-2.5.56/drivers/scsi/hosts.c 2003-01-10 21:11:20.000000000
> +0100
> +++ linux-2.5.56-work/drivers/scsi/hosts.c 2003-01-12
> 12:42:59.000000000 +0100
> @@ -345,7 +345,9 @@
> shost->hostt->present--;
>
> /* Cleanup proc */
> +#ifdef CONFIG_PROC_FS
> scsi_proc_host_rm(shost);
> +#endif
>
> kfree(shost);
> }
> @@ -456,7 +458,9 @@
> found:
> spin_unlock(&scsi_host_list_lock);
>
> +#ifdef CONFIG_PROC_FS
> scsi_proc_host_add(shost);
> +#endif
>
> shost->eh_notify = &sem;
> kernel_thread((int (*)(void *)) scsi_error_handler, (void *)
> shost, 0);
>
Paul -
This should really be:
--- 1.54/drivers/scsi/scsi.h Sat Dec 21 08:54:22 2002
+++ edited/drivers/scsi/scsi.h Mon Jan 13 11:35:11 2003
@@ -502,8 +502,8 @@
static inline void scsi_exit_procfs(void) { ; }
static inline void proc_print_scsidevice(Scsi_Device * sdev, char *buffer, int *size, int len) { ; }
-static inline void scsi_proc_host_add(struct Scsi_Host *);
-static inline void scsi_proc_host_rm(struct Scsi_Host *);
+static inline void scsi_proc_host_add(struct Scsi_Host *shost) { ; }
+static inline void scsi_proc_host_rm(struct Scsi_Host *shost) { ; }
#endif /* CONFIG_PROC_FS */
/*
-- Patrick Mansfield
parent reply other threads:[~2003-01-13 20:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <009001c2ba32$3b4bcdf0$2101a8c0@witbe>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030113121657.A16667@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rol@as2917.net \
--cc=rol@witbe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox