From: Mike Anderson <andmike@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: David_Jeffery@adaptec.com
Subject: [PATCH] 2.5 ips.c pci_module_init
Date: Thu, 16 Jan 2003 15:09:37 -0800 [thread overview]
Message-ID: <20030116230937.GA5561@beaverton.ibm.com> (raw)
This patch is against 2.5.58 but also applies to scsi-misc-2.5 with a
offset 1 line warning.
This error started near 2.5.56 with badness warnings when the driver
loaded and has progressed to the driver probe routine not being called
at all as sysfs error propagation patches have been added. Since my
ServeRAID card is old it is the last pci_module_init to be called.
The patch just changes the name field in the ips pci_driver struct as
the three pci_driver names where not unique and cause EEXIST errors.
I have cc'd David Jeffery the driver maintainer.
-andmike
--
Michael Anderson
andmike@us.ibm.com
ips.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
------
--- 1.38/drivers/scsi/ips.c Fri Jan 10 11:40:07 2003
+++ edited/drivers/scsi/ips.c Thu Jan 16 11:42:00 2003
@@ -271,27 +271,25 @@
MODULE_DEVICE_TABLE( pci, ips_pci_table );
- static char ips_hot_plug_name[] = "ips";
-
static int __devinit ips_insert_device(struct pci_dev *pci_dev, const struct pci_device_id *ent);
static void __devexit ips_remove_device(struct pci_dev *pci_dev);
struct pci_driver ips_pci_driver = {
- .name = ips_hot_plug_name,
+ .name = "ips",
.id_table = ips_pci_table,
.probe = ips_insert_device,
.remove = __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_5i = {
- .name = ips_hot_plug_name,
+ .name = "ips_5i",
.id_table = ips_pci_table_5i,
.probe = ips_insert_device,
.remove = __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_i960 = {
- .name = ips_hot_plug_name,
+ .name = "ips_i960",
.id_table = ips_pci_table_i960,
.probe = ips_insert_device,
.remove = __devexit_p(ips_remove_device),
next reply other threads:[~2003-01-16 23:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-16 23:09 Mike Anderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-01-17 17:45 [PATCH] 2.5 ips.c pci_module_init Jeffery, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030116230937.GA5561@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=David_Jeffery@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox