From: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
To: Greg KH <greg@kroah.com>,
USB Developers <linux-usb-devel@lists.sourceforge.net>,
USB Storage List <usb-storage@one-eyed-alien.net>,
Mike Anderson <andmike@us.ibm.com>,
Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: PATCH: usb-storage: fix typo
Date: Sun, 19 Jan 2003 17:16:02 -0800 [thread overview]
Message-ID: <20030119171602.D31114@one-eyed-alien.net> (raw)
In-Reply-To: <20030119143058.A31114@one-eyed-alien.net>; from mdharm-usb@one-eyed-alien.net on Sun, Jan 19, 2003 at 02:30:58PM -0800
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
This patch goes on top of the last one. It fixes a typo in the test for
scsi_register() failure.
Please apply.
Matt
# This is a BitKeeper generated patch for the following project:
# Project Name: greg k-h's linux 2.5 USB kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.667 -> 1.668
# drivers/usb/storage/usb.c 1.68 -> 1.69
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/01/19 mdharm@zen.san.one-eyed-alien.net 1.668
# Fix a typo -- reversed the logic of failure test for scsi_register()
# --------------------------------------------
#
diff -Nru a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
--- a/drivers/usb/storage/usb.c Sun Jan 19 17:15:18 2003
+++ b/drivers/usb/storage/usb.c Sun Jan 19 17:15:18 2003
@@ -912,7 +912,7 @@
/* now register */
ss->host = scsi_register(&usb_stor_host_template, sizeof(ss));
- if (ss->host) {
+ if (!ss->host) {
printk(KERN_WARNING USB_STORAGE
"Unable to register the scsi host\n");
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I don't have a left mouse button. I only have one mouse and it's on my right.
-- Customer
User Friendly, 2/13/1999
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2003-01-20 1:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-19 22:30 PATCH: usb-storage: move to SCSI hotplugging Matthew Dharm
2003-01-19 22:56 ` Oliver Neukum
2003-01-20 1:11 ` Matthew Dharm
2003-01-20 1:16 ` Matthew Dharm [this message]
2003-01-23 4:43 ` PATCH: usb-storage: fix typo Greg KH
2003-01-23 19:40 ` Matthew Dharm
2003-01-24 8:26 ` Greg KH
2003-01-25 18:11 ` [linux-usb-devel] " Matthew Dharm
2003-01-25 20:32 ` Matthew Dharm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030119171602.D31114@one-eyed-alien.net \
--to=mdharm-scsi@one-eyed-alien.net \
--cc=andmike@us.ibm.com \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=usb-storage@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox