Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.58

Mike Anderson
2003-02-26T23:37:02Z

Matthew,
Sorry for the delay in replying (non coding activities are
consuming to many hours).

Matthew Dharm [mdharm-scsi@one-eyed-alien.net] wrote:
> Okay, I see Linus has now accepted this into his tree. It should propagate
> to the USB development trees soon.
>
> One question: What else is needed? We set the device offline,
> error/complete all pending commands, and the need to (somehow) make certain
> we're in a good state for calling scsi_remove_host(). How do we make that
> final guarantee?
>
> There was talk that scsi_set_device_offline() would take care of that for
> us by waking up the error handler... there seems to be code to do that....
>

Yes,

The scsi_set_device_offline will wake up the error handler to abort
outstanding commands.

> There was talk of using the release() function from the SCSI template to
> actually release resources....
>
> So, what's the plan?

There still are a few things on the to do list, but should not effect the
LLDD interface (at least this is the goal).
- scsi_request_fn needs a fix for device offline that will
handle all request types.
- scsi_remove_host needs to call template release at the correct
time (ref counting ??).
- need fix for offline hotplug event.
- Should do_hotplug be exported or should device states
be added / fixed ??

Cleanups
- Change scsi_remove_host for int to void function.

-andmike
--
Michael Anderson
andmike@us.ibm.com