Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.58

greg kh
2003-01-16T22:50:24Z

Copied to linux-usb-devel, as they should also see this...

On Thu, 16 Jan 2003 12:10:18 -0800, Linus Torvalds wrote:

> In article <20030116195306.GA32697@kroah.com>, Greg KH <greg@kroah.com>
> wrote:
>>On Thu, Jan 16, 2003 at 11:43:23AM -0800, Matthew Dharm wrote:
>>> Well, we only create the host when the device is first attached. After
>>> that, if it goes away and comes back, we re-connect it to the old SCSI
>>> host.
>>
>>Ick, so when the device is gone, where does the SCSI host go? Is it
>>still represented in sysfs and in the SCSI core properly?
>
> This is pure and utter USB storage stupidity, and nothing else.
>
> When the USB storage device is unplugged, the device should be
> unregistered. It should be _gone_. It isn't sleeping, it's dead. It's
> an ex-device.

Agreed, I thought most of that logic had been removed from the
usb-storage driver as the SCSI layer can now handle removing devices just
fine (or so Mike Anderson tells me :)

thanks,

greg k-h