[PATCH] fix scsi add-single-device

James Bottomley
2003-01-26T18:01:03Z

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

There was a logic typo in the abstraction of scsi_add_single_device()
that meant it could never work.

The attached patch fixes it.

James

[-- Attachment #2: Type: text/plain, Size: 1102 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.958 -> 1.959
# drivers/scsi/scsi_scan.c 1.52 -> 1.53
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/01/26 jejb@mulgrave.(none) 1.959
# [SCSI] make echo scsi add-single-device x x x x > /proc/scsi/scsi work again
#
# Correct the logic error making it fail
# --------------------------------------------
#
diff -Nru a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
--- a/drivers/scsi/scsi_scan.c Sun Jan 26 11:58:46 2003
+++ b/drivers/scsi/scsi_scan.c Sun Jan 26 11:58:46 2003
@@ -1758,7 +1758,7 @@
shost = scsi_host_hn_get(host);
if (!shost)
return -ENODEV;
- if(scsi_find_device(shost, channel, id, lun) != NULL)
+ if(scsi_find_device(shost, channel, id, lun) == NULL)
goto out;

if (scsi_probe_and_add_lun(shost, NULL, channel, id, lun, NULL) ==