* [TRIVIAL] [Trivial Patch] scsi_register-002
@ 2002-11-08 8:25 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-11-08 8:25 UTC (permalink / raw)
To: linux-scsi, alan
From: Michael Still <mikal@stillhq.com>
This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here...
--- trivial-2.5-bk/drivers/scsi/aacraid/linit.c.orig 2002-11-08 18:47:02.000000000 +1100
+++ trivial-2.5-bk/drivers/scsi/aacraid/linit.c 2002-11-08 18:47:02.000000000 +1100
@@ -204,6 +204,9 @@
* specific information.
*/
host_ptr = scsi_register( template, sizeof(struct aac_dev) );
+ if(host_ptr == NULL)
+ continue;
+
/*
* These three parameters can be used to allow for wide SCSI
* and for host adapters that support multiple buses.
--
Don't blame me: the Monkey is driving
File: Michael Still <mikal@stillhq.com>: [Trivial Patch] scsi_register-002
^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL] [Trivial Patch] scsi_register-002
@ 2002-12-16 10:39 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-12-16 10:39 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-scsi
(Included in 2.5)
From: Michael Still <mikal@stillhq.com>
This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here...
--- trivial-2.4.21-pre1/drivers/scsi/aacraid/linit.c.orig 2002-12-16 17:22:28.000000000 +1100
+++ trivial-2.4.21-pre1/drivers/scsi/aacraid/linit.c 2002-12-16 17:22:28.000000000 +1100
@@ -203,6 +203,9 @@
* specific information.
*/
host_ptr = scsi_register( template, sizeof(struct aac_dev) );
+ if(host_ptr == NULL)
+ continue;
+
/*
* These three parameters can be used to allow for wide SCSI
* and for host adapters that support multiple buses.
--
Don't blame me: the Monkey is driving
File: Michael Still <mikal@stillhq.com>: [Trivial Patch] scsi_register-002
^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL] [Trivial Patch] scsi_register-002
@ 2003-02-06 3:11 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2003-02-06 3:11 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-scsi
(Included in 2.5)
From: Michael Still <mikal@stillhq.com>
This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here...
--- trivial-2.4.21-pre4/drivers/scsi/aacraid/linit.c.orig 2003-02-06 13:53:49.000000000 +1100
+++ trivial-2.4.21-pre4/drivers/scsi/aacraid/linit.c 2003-02-06 13:53:49.000000000 +1100
@@ -203,6 +203,9 @@
* specific information.
*/
host_ptr = scsi_register( template, sizeof(struct aac_dev) );
+ if(host_ptr == NULL)
+ continue;
+
/*
* These three parameters can be used to allow for wide SCSI
* and for host adapters that support multiple buses.
--
Don't blame me: the Monkey is driving
File: Michael Still <mikal@stillhq.com>: [Trivial Patch] scsi_register-002
^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL] [Trivial Patch] scsi_register-002
@ 2003-06-23 6:56 Rusty Trivial Russell
2003-06-23 14:17 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Rusty Trivial Russell @ 2003-06-23 6:56 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: aacraid, linux-scsi
(Included in 2.5)
From: Michael Still <mikal@stillhq.com>
This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here...
--- trivial-2.4.22-pre1/drivers/scsi/aacraid/linit.c.orig 2003-06-23 16:39:34.000000000 +1000
+++ trivial-2.4.22-pre1/drivers/scsi/aacraid/linit.c 2003-06-23 16:39:34.000000000 +1000
@@ -203,6 +203,9 @@
* specific information.
*/
host_ptr = scsi_register( template, sizeof(struct aac_dev) );
+ if(host_ptr == NULL)
+ continue;
+
/*
* These three parameters can be used to allow for wide SCSI
* and for host adapters that support multiple buses.
--
What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
Don't blame me: the Monkey is driving
File: Michael Still <mikal@stillhq.com>: [Trivial Patch] scsi_register-002
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL] [Trivial Patch] scsi_register-002
2003-06-23 6:56 Rusty Trivial Russell
@ 2003-06-23 14:17 ` Alan Cox
2003-06-23 15:42 ` Rusty Russell
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2003-06-23 14:17 UTC (permalink / raw)
To: Rusty Trivial Russell; +Cc: Marcelo Tosatti, aacraid, linux-scsi
On Llu, 2003-06-23 at 07:56, Rusty Trivial Russell wrote:
> (Included in 2.5)
> From: Michael Still <mikal@stillhq.com>
>
>
> This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here...
Fix is subtly wrong because of aac_count, fixed up in my tree will push
to Marcelo with the rest of the aacraid updates soon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL] [Trivial Patch] scsi_register-002
2003-06-23 14:17 ` Alan Cox
@ 2003-06-23 15:42 ` Rusty Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Russell @ 2003-06-23 15:42 UTC (permalink / raw)
To: Alan Cox; +Cc: aacraid, linux-scsi
In message <1056377839.13528.46.camel@dhcp22.swansea.linux.org.uk> you write:
> On Llu, 2003-06-23 at 07:56, Rusty Trivial Russell wrote:
> > (Included in 2.5)
> > From: Michael Still <mikal@stillhq.com>
> >
> >
> > This patch has been generated as part of my scsi_register audit of the 2.
5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the f
ailure case was not being handled here...
>
> Fix is subtly wrong because of aac_count, fixed up in my tree will push
> to Marcelo with the rest of the aacraid updates soon
Are you planning on updating the 2.5 one too? This patch went in 2.5,
as indicated above, which is bad...
Thanks!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-06-23 23:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-06 3:11 [TRIVIAL] [Trivial Patch] scsi_register-002 Rusty Trivial Russell
-- strict thread matches above, loose matches on Subject: below --
2003-06-23 6:56 Rusty Trivial Russell
2003-06-23 14:17 ` Alan Cox
2003-06-23 15:42 ` Rusty Russell
2002-12-16 10:39 Rusty Trivial Russell
2002-11-08 8:25 Rusty Trivial Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox