From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Steven Dake <sdake@mvista.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: why store the search type in the ieee name field?
Date: Tue, 11 Feb 2003 08:46:56 -0800 [thread overview]
Message-ID: <20030211084656.A27826@beaverton.ibm.com> (raw)
In-Reply-To: <1044981839.1774.10.camel@mulgrave>; from James.Bottomley@steeleye.com on Tue, Feb 11, 2003 at 10:43:57AM -0600
On Tue, Feb 11, 2003 at 10:43:57AM -0600, James Bottomley wrote:
> No, look at the code. After doing name[0] = hex_str[...
> it then does a strcat. If name is full of junk, strcat will append
> after the first \0 it finds (which may be off the end of the name
> field). It only works because name[1] is zero but nothing seems to
> clear it. I'm hoping it's being cleared in a piece of code I haven't
> found yet...
>
> James
Yes - there's a memset() in scsi_load_identifier, plus on error some of
the fields are re-zeroed (a bit ugly).
-- Patrick Mansfield
next prev parent reply other threads:[~2003-02-11 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-10 22:45 why store the search type in the ieee name field? Steven Dake
2003-02-10 23:12 ` James Bottomley
2003-02-11 16:20 ` Patrick Mansfield
2003-02-11 16:43 ` James Bottomley
2003-02-11 16:46 ` Patrick Mansfield [this message]
2003-02-11 17:38 ` Steven Dake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030211084656.A27826@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sdake@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox