From: Oliver Neukum <oliver@neukum.name>
To: Mike Anderson <andmike@us.ibm.com>, linux-scsi@vger.kernel.org
Cc: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
Subject: Re: [PATCH / RFC] scsi_set_host_offline
Date: Wed, 5 Mar 2003 00:12:35 +0100 [thread overview]
Message-ID: <200303050012.35309.oliver@neukum.name> (raw)
In-Reply-To: <20030304222907.GA1252@beaverton.ibm.com>
> If a LLDD decided that it did not want any more devices added it can
> today fail calls to queuecommand or slave_alloc (which some already do).
> The LLDD may need to handle these in the future depending on what
> functions scsi_set_host_offline maybe racing with.
It seems to me that there's a race with scan_scsis() and scan_scsis_single()
which cannot be closed with failing queuecommand, as there's a window where
the INQUIRY has succeeded but has not yet been evaluated by the SCSI layer.
I am not quite sure how slave_alloc() is involved into this, but IMHO it's
wrong to force LLDDs to know about devices if they are hotpluggable.
Could you clarify?
Regards
Oliver
next prev parent reply other threads:[~2003-03-04 23:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 22:15 [PATCH / RFC] scsi_set_host_offline Mike Anderson
2003-03-04 0:03 ` Oliver Neukum
2003-03-04 20:36 ` Matthew Dharm
2003-03-04 20:57 ` Oliver Neukum
2003-03-04 22:29 ` Mike Anderson
2003-03-04 23:12 ` Oliver Neukum [this message]
2003-03-05 16:52 ` James Bottomley
2003-03-05 19:49 ` Oliver Neukum
2003-03-05 22:35 ` Mike Anderson
2003-03-06 14:33 ` Oliver Neukum
2003-03-04 0:08 ` Patrick Mansfield
2003-03-22 21:24 ` Matthew Dharm
2003-03-25 9:46 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303050012.35309.oliver@neukum.name \
--to=oliver@neukum.name \
--cc=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-scsi@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox