[rob@osinvestor.com: Re: SCSI broken]

[rob@osinvestor.com: Re: SCSI broken]

[Rob Radez]

[forgot to cc: linux-scsi@]

Also forgot to mention that 2.5.64 hangs in the same spot as 2.5.63.

----- Forwarded message from Rob Radez <rob@osinvestor.com> -----

From: rob@osinvestor.com (Rob Radez)
To: David van Hoose <davidvh@cox.net>
Cc: linux-kernel@vger.kernel.org
Date: Wed, 5 Mar 2003 00:44:57 -0500
Subject: Re: SCSI broken

On Tue, Mar 04, 2003 at 11:42:41PM -0600, David van Hoose wrote:
> Kernels 2.5.63 and 2.5.64 lock up when displaying the information for my 
> ZipDrive during SCSI probe. Attached is my .config for 2.5.64.

I suspect I'm seeing something similar.  On SPARC, I'm getting a hang
after displaying the information for my SCSI CD-ROM drive.

scsi0 : Sparc ESP100A-FAST
Vendor: SEAGATE   Model: ST31200W SUN1.05  Rev: 8724
Type:   Direct-Access                      ANSI SCSI revision: 02
Vendor: SEAGATE   Model: ST32155W SUN2.1G  Rev: 8456
Type:   Direct-Access                      ANSI SCSI revision: 02
Vendor: TOSHIBA   Model: XM-4101TASUNSLCD  Rev: 1755
Type:   CD-ROM                             ANSI SCSI revision: 02
<hang>

.config available on request.  Worked fine in 2.5.62, hangs in 2.5.63.
Reverting the scsi changes listed at
http://osinvestor.com/sparc/patch/2.5.63-revertscsi.diff allows 2.5.63
to boot.

Regards,
Rob Radez
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----

Re: [rob@osinvestor.com: Re: SCSI broken]

[Mike Anderson]

Rob,
	Would it possible for you to build with CONFIG_SCSI_LOGGING=y
	and boot with scsi_logging=1. Then send the output to me.  The
	output is quite noisy and if you do not have a serial connected
	the last messages maybe all that is needed. This would help
	narrow down the section in the diff.

Rob Radez [rob@osinvestor.com] wrote:
> [forgot to cc: linux-scsi@]
> 
> Also forgot to mention that 2.5.64 hangs in the same spot as 2.5.63.
> 
> ----- Forwarded message from Rob Radez <rob@osinvestor.com> -----
> 
> From: rob@osinvestor.com (Rob Radez)
> To: David van Hoose <davidvh@cox.net>
> Cc: linux-kernel@vger.kernel.org
> Date: Wed, 5 Mar 2003 00:44:57 -0500
> Subject: Re: SCSI broken
> 
> On Tue, Mar 04, 2003 at 11:42:41PM -0600, David van Hoose wrote:
> > Kernels 2.5.63 and 2.5.64 lock up when displaying the information for my 
> > ZipDrive during SCSI probe. Attached is my .config for 2.5.64.
> 
> I suspect I'm seeing something similar.  On SPARC, I'm getting a hang
> after displaying the information for my SCSI CD-ROM drive.
> 
> scsi0 : Sparc ESP100A-FAST
> Vendor: SEAGATE   Model: ST31200W SUN1.05  Rev: 8724
> Type:   Direct-Access                      ANSI SCSI revision: 02
> Vendor: SEAGATE   Model: ST32155W SUN2.1G  Rev: 8456
> Type:   Direct-Access                      ANSI SCSI revision: 02
> Vendor: TOSHIBA   Model: XM-4101TASUNSLCD  Rev: 1755
> Type:   CD-ROM                             ANSI SCSI revision: 02
> <hang>
> 
> .config available on request.  Worked fine in 2.5.62, hangs in 2.5.63.
> Reverting the scsi changes listed at
> http://osinvestor.com/sparc/patch/2.5.63-revertscsi.diff allows 2.5.63
> to boot.
> 
> Regards,
> Rob Radez
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> ----- End forwarded message -----
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-andmike
--
Michael Anderson
andmike@us.ibm.com

Re: [rob@osinvestor.com: Re: SCSI broken]

[Mike Anderson]

Rob,
	The patch below fixed a error handler problem on my system when
	I switch to using the old aic7xxx. Could you try it and let me
	know if it fixes your problem.

I had my list empty checks reversed if aborting and bus device reset
failed. The condition that causes the error handler to run is config
related and I cannot recreate your config with my equipment.

Mike Anderson [andmike@us.ibm.com] wrote:
> Rob,
> 	Would it possible for you to build with CONFIG_SCSI_LOGGING=y
> 	and boot with scsi_logging=1. Then send the output to me.  The
> 	output is quite noisy and if you do not have a serial connected
> 	the last messages maybe all that is needed. This would help
> 	narrow down the section in the diff.
> 
-andmike
--
Michael Anderson
andmike@us.ibm.com


=====
name:		00_scsi_error_ready_devs-1.diff
version:	2003-03-05.10:39:28-0800
against:	2.5.63

 scsi_error.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

=====
===== drivers/scsi/scsi_error.c 1.38 vs edited =====
--- 1.38/drivers/scsi/scsi_error.c	Sat Feb 22 08:17:01 2003
+++ edited/drivers/scsi/scsi_error.c	Wed Mar  5 10:14:22 2003
@@ -1490,9 +1490,9 @@
 			       struct list_head *work_q,
 			       struct list_head *done_q)
 {
-	if (scsi_eh_bus_device_reset(shost, work_q, done_q))
-		if (scsi_eh_bus_reset(shost, work_q, done_q))
-			if (scsi_eh_host_reset(work_q, done_q))
+	if (!scsi_eh_bus_device_reset(shost, work_q, done_q))
+		if (!scsi_eh_bus_reset(shost, work_q, done_q))
+			if (!scsi_eh_host_reset(work_q, done_q))
 				scsi_eh_offline_sdevs(work_q, done_q);
 }