From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Anderson Subject: Re: 2.5.63/64 do not boot: loop in scsi_error Date: Thu, 6 Mar 2003 10:14:09 -0800 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <20030306181408.GC1203@beaverton.ibm.com> References: <20030306083054.GB1503@beaverton.ibm.com> <20030306085506.GB2222@beaverton.ibm.com> <20030306091824.GA2577@beaverton.ibm.com> <1046968304.1746.20.camel@mulgrave> <1046971303.1998.23.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: To: Zwane Mwaikambo Cc: James Bottomley , Andries.Brouwer@cwi.nl, torvalds@transmeta.com, linux-kernel@vger.kernel.org, SCSI Mailing List List-Id: linux-scsi@vger.kernel.org Zwane Mwaikambo [zwane@linuxpower.ca] wrote: > On Thu, 6 Mar 2003, James Bottomley wrote: > > > Actually, all three if's need nots in front: > > > > diff -Nru a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > --- a/drivers/scsi/scsi_error.c Thu Mar 6 11:21:22 2003 > > +++ b/drivers/scsi/scsi_error.c Thu Mar 6 11:21:22 2003 > > @@ -1490,9 +1490,9 @@ > > struct list_head *work_q, > > struct list_head *done_q) > > { > > - if (scsi_eh_bus_device_reset(shost, work_q, done_q)) > > - if (scsi_eh_bus_reset(shost, work_q, done_q)) > > - if (scsi_eh_host_reset(work_q, done_q)) > > + if (!scsi_eh_bus_device_reset(shost, work_q, done_q)) > > + if (!scsi_eh_bus_reset(shost, work_q, done_q)) > > + if (!scsi_eh_host_reset(work_q, done_q)) > > scsi_eh_offline_sdevs(work_q, done_q); > > } > > Ok patched 2.5.63 is back to booting as 2.5.62, would you like any more > information? > I believe we have all the information we need. Thanks for sending the previous data and trying the patch. I still need to understand the error signature for Andries as it sounds different then what you are seeing. -andmike -- Michael Anderson andmike@us.ibm.com