From: Christoph Hellwig <hch@infradead.org>
To: Luben Tuikov <luben@splentec.com>
Cc: Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] softirq queue is now list_head, eliminate bh_next]
Date: Sat, 8 Mar 2003 18:08:19 +0000 [thread overview]
Message-ID: <20030308180819.A30285@infradead.org> (raw)
In-Reply-To: <3E6A2EBE.5050508@splentec.com>; from luben@splentec.com on Sat, Mar 08, 2003 at 12:56:14PM -0500
On Sat, Mar 08, 2003 at 12:56:14PM -0500, Luben Tuikov wrote:
> The only comment I put after a closing brace of a function
> definition is /* end of fn_name() */ so that one can see
> which function ends if its definition (code) is only partly
> shown in one's screen.
> I hope that's ok with everyone? If not, flame me now.
No need for a flame, but please remove the comment, there is a strong
tendency against this style of commenting in the core kernel code.
A related note from the CondingStyle document:
Functions should be short and sweet, and do just one thing. They should
fit on one or two screenfuls of text (the ISO/ANSI screen size is 80x24,
as we all know), and do one thing and do that well.
You're _code_ is actually fine regarding to that so you shouldn't need the
comments :)
next prev parent reply other threads:[~2003-03-08 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-08 17:56 [PATCH] softirq queue is now list_head, eliminate bh_next] Luben Tuikov
2003-03-08 18:08 ` Christoph Hellwig [this message]
2003-03-09 16:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030308180819.A30285@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luben@splentec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox