From: Willem Riede <wrlk@riede.org>
To: Christoph Hellwig <hch@lst.de>
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix jiffies compare warning in osst
Date: Tue, 11 Mar 2003 18:52:29 -0500 [thread overview]
Message-ID: <20030311235229.GG7082@linnie.riede.org> (raw)
In-Reply-To: <20030311201301.B986@lst.de>; from hch@lst.de on Tue, Mar 11, 2003 at 14:13:01 -0500
On 2003.03.11 14:13 Christoph Hellwig wrote:
>
> --- 1.39/drivers/scsi/osst.c Sun Feb 2 17:50:23 2003
> +++ edited/drivers/scsi/osst.c Mon Mar 10 14:35:46 2003
> @@ -777,7 +777,7 @@
> #define OSST_POLL_PER_SEC 10
> static int osst_wait_frame(OS_Scsi_Tape * STp, Scsi_Request ** aSRpnt, int curr, int minlast, int to)
> {
> - long startwait = jiffies;
> + unsigned long startwait = jiffies;
> char * name = tape_name(STp);
> #if DEBUG
> char notyetprinted = 1;
> @@ -1288,7 +1288,7 @@
> int logical_blk_num = ntohl(STp->buffer->aux->logical_blk_num)
> - (nframes + pending - 1) * blks_per_frame;
> char * name = tape_name(STp);
> - long startwait = jiffies;
> + unsigned long startwait = jiffies;
> #if DEBUG
> int dbg = debugging;
> #endif
> @@ -1477,7 +1477,7 @@
> int expected = 0;
> int attempts = 1000 / skip;
> int flag = 1;
> - long startwait = jiffies;
> + unsigned long startwait = jiffies;
> #if DEBUG
> int dbg = debugging;
> #endif
> -
There are five functions that use jiffies. You fixed three of them.
If this change is done (and that's fine with me) it should be done
with this patch:
--- /home/wriede/develop/Driver25/osst.c Thu Jan 30 18:34:38 2003
+++ osst.c Tue Mar 11 18:46:48 2003
@@ -607,7 +607,7 @@
{
unsigned char cmd[MAX_COMMAND_SIZE];
Scsi_Request * SRpnt;
- long startwait = jiffies;
+ unsigned long startwait = jiffies;
#if DEBUG
int dbg = debugging;
char * name = tape_name(STp);
@@ -674,7 +674,7 @@
{
unsigned char cmd[MAX_COMMAND_SIZE];
Scsi_Request * SRpnt;
- long startwait = jiffies;
+ unsigned long startwait = jiffies;
#if DEBUG
int dbg = debugging;
char * name = tape_name(STp);
@@ -778,8 +778,8 @@
#define OSST_POLL_PER_SEC 10
static int osst_wait_frame(OS_Scsi_Tape * STp, Scsi_Request ** aSRpnt, int curr, int minlast, int to)
{
- long startwait = jiffies;
- char * name = tape_name(STp);
+ unsigned long startwait = jiffies;
+ char * name = tape_name(STp);
#if DEBUG
char notyetprinted = 1;
#endif
@@ -1289,7 +1289,7 @@
int logical_blk_num = ntohl(STp->buffer->aux->logical_blk_num)
- (nframes + pending - 1) * blks_per_frame;
char * name = tape_name(STp);
- long startwait = jiffies;
+ unsigned long startwait = jiffies;
#if DEBUG
int dbg = debugging;
#endif
@@ -1478,7 +1478,7 @@
int expected = 0;
int attempts = 1000 / skip;
int flag = 1;
- long startwait = jiffies;
+ unsigned long startwait = jiffies;
#if DEBUG
int dbg = debugging;
#endif
Thanks, Willem Riede.
prev parent reply other threads:[~2003-03-11 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-11 19:13 [PATCH] fix jiffies compare warning in osst Christoph Hellwig
2003-03-11 23:52 ` Willem Riede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030311235229.GG7082@linnie.riede.org \
--to=wrlk@riede.org \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox