From: Christoph Hellwig <hch@lst.de>
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] fix rescan warning
Date: Mon, 17 Mar 2003 16:53:02 +0100 [thread overview]
Message-ID: <20030317165301.B29420@lst.de> (raw)
The prototype for scsi_rescan_device was missing and once added it's
caller doesn't compile anymore because it expects a return value..
--- 1.67/drivers/scsi/scsi.h Sat Mar 15 01:35:26 2003
+++ edited/drivers/scsi/scsi.h Mon Mar 17 16:04:49 2003
@@ -442,6 +442,7 @@
extern int scsi_retry_command(Scsi_Cmnd *);
extern int scsi_attach_device(struct scsi_device *);
extern void scsi_detach_device(struct scsi_device *);
+extern void scsi_rescan_device(struct scsi_device *);
extern int scsi_get_device_flags(unsigned char *vendor, unsigned char *model);
/*
--- 1.8/drivers/scsi/scsi_sysfs.c Tue Mar 4 10:15:42 2003
+++ edited/drivers/scsi/scsi_sysfs.c Mon Mar 17 16:30:31 2003
@@ -275,12 +275,8 @@
static ssize_t
store_rescan_field (struct device *dev, const char *buf, size_t count)
{
- int ret = ENODEV;
- struct scsi_device *sdev;
- sdev = to_scsi_device(dev);
- if (sdev)
- ret = scsi_rescan_device(sdev);
- return ret;
+ scsi_rescan_device(to_scsi_device(dev));
+ return 0;
}
static DEVICE_ATTR(rescan, S_IRUGO | S_IWUSR, show_rescan_field, store_rescan_field)
next reply other threads:[~2003-03-17 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-17 15:53 Christoph Hellwig [this message]
2003-03-18 1:18 ` [PATCH] fix rescan warning Douglas Gilbert
2003-03-18 8:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030317165301.B29420@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox