From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Mansfield Subject: Re: [PATCH] scsi_set_host_offline (resend) Date: Fri, 28 Mar 2003 16:31:09 -0800 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20030328163109.A22830@beaverton.ibm.com> References: <20030325100704.GC3868@beaverton.ibm.com> <1048613872.2070.12.camel@mulgrave> <20030325184530.GA1202@beaverton.ibm.com> <1048618939.1790.29.camel@mulgrave> <20030325232920.GB2692@beaverton.ibm.com> <1048779761.1789.21.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1048779761.1789.21.camel@mulgrave>; from James.Bottomley@steeleye.com on Thu, Mar 27, 2003 at 09:42:39AM -0600 List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Mike Anderson , mochel@osdl.org, SCSI Mailing List On Thu, Mar 27, 2003 at 09:42:39AM -0600, James Bottomley wrote: > On Tue, 2003-03-25 at 17:29, Mike Anderson wrote: > > I thought we where looking at a solution for all traversals of the list? > > There are currently ~52 refs to my_devices, while some traversals can be > > evalutated and possibly removed there maybe valid ones that happen > > without user context. > > Sorry, I was thinking both short and long term. > > Short term, it's probably easiest for the firewire stuff to access the > offline and removal functions from user land hotplug scripts (so they > don't actually need the in-kernel hook). > > Long term we do need to see if we can go to a nice refcounted model for > all 50 odd list traversals. At least auditing them to see if we can use > a semaphore everywhere. > > James same_target_siblings has a similiar problem. It is used primarily for the single_lun code, sometimes in softirq context (should really not sleep there), and also to get any exisiting scsi_level during scan. -- Patrick Mansfield