From: Patrick Mansfield <patmans@us.ibm.com>
To: linux-scsi@vger.kernel.org
Subject: 2.5.x why a conditional call to blkdev_dequeue_request?
Date: Mon, 7 Apr 2003 20:40:05 -0700 [thread overview]
Message-ID: <20030407204005.A4219@beaverton.ibm.com> (raw)
Why do we conditionally call blkdev_dequeue_request, and yet run the same
code even if a request is not dequeued?
Should we always call blkdev_dequeue_request, and handle
blk_queue_start_tag() returning != 0 as a bug or a resource limitation?
In 2.5 scsi_lib.c scsi_request_fn right now we have:
if (!(blk_queue_tagged(q) && (blk_queue_start_tag(q, req) == 0)))
blkdev_dequeue_request(req);
/* then handle the request whether it was dequeued or not */
-- Patrick Mansfield
next reply other threads:[~2003-04-08 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-08 3:40 Patrick Mansfield [this message]
2003-04-08 4:13 ` 2.5.x why a conditional call to blkdev_dequeue_request? James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030407204005.A4219@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox