From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: [patch] 4/5 scsi-locking-2.5 list_del starved_entry plus use GFP_ATOMIC
Date: Wed, 9 Apr 2003 16:47:56 -0700 [thread overview]
Message-ID: <20030409164756.D23701@beaverton.ibm.com> (raw)
In-Reply-To: <20030409164733.C23701@beaverton.ibm.com>; from patmans@us.ibm.com on Wed, Apr 09, 2003 at 04:47:33PM -0700
list_del the starved_entry when sdev goes away.
Use GFP_ATOMIC when allocating starget, since we hold a lock.
diff -purN -X /home/patman/dontdiff 03_no_loop/drivers/scsi/scsi_scan.c 04_scan_changes/drivers/scsi/scsi_scan.c
--- 03_no_loop/drivers/scsi/scsi_scan.c Wed Apr 9 12:39:15 2003
+++ 04_scan_changes/drivers/scsi/scsi_scan.c Wed Apr 9 13:37:02 2003
@@ -489,13 +489,14 @@ static void scsi_free_sdev(struct scsi_d
sdev->host->hostt->slave_destroy(sdev);
if (sdev->inquiry)
kfree(sdev->inquiry);
+ spin_lock_irqsave(sdev->host->host_lock, flags);
+ list_del(&sdev->starved_entry);
if (sdev->single_lun) {
- spin_lock_irqsave(sdev->host->host_lock, flags);
sdev->sdev_target->starget_refcnt--;
if (sdev->sdev_target->starget_refcnt == 0)
kfree(sdev->sdev_target);
- spin_unlock_irqrestore(sdev->host->host_lock, flags);
}
+ spin_unlock_irqrestore(sdev->host->host_lock, flags);
kfree(sdev);
}
@@ -1275,7 +1276,7 @@ static int scsi_add_lun(Scsi_Device *sde
}
}
if (!starget) {
- starget = kmalloc(sizeof(*starget), GFP_KERNEL);
+ starget = kmalloc(sizeof(*starget), GFP_ATOMIC);
if (!starget) {
printk(ALLOC_FAILURE_MSG, __FUNCTION__);
spin_unlock_irqrestore(sdev->host->host_lock,
next prev parent reply other threads:[~2003-04-09 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-09 23:46 [patch] 1/5 scsi-locking-2.5 single_lun store scsi_device pointer Patrick Mansfield
2003-04-09 23:47 ` [patch] 2/5 scsi-locking-2.5 remove lock hierarchy Patrick Mansfield
2003-04-09 23:47 ` [patch] 3/5 scsi-locking-2.5 prevent looping when processing starved queues Patrick Mansfield
2003-04-09 23:47 ` Patrick Mansfield [this message]
2003-04-09 23:48 ` [patch] 5/5 scsi-locking-2.5 remove extra sdev2, remove extra logging Patrick Mansfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030409164756.D23701@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox