From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: [patch] 5/5 scsi-locking-2.5 remove extra sdev2, remove extra logging
Date: Wed, 9 Apr 2003 16:48:20 -0700 [thread overview]
Message-ID: <20030409164820.E23701@beaverton.ibm.com> (raw)
In-Reply-To: <20030409164756.D23701@beaverton.ibm.com>; from patmans@us.ibm.com on Wed, Apr 09, 2003 at 04:47:56PM -0700
Remove unneeded sdev2 variable.
Remove extra log message.
diff -purN -X /home/patman/dontdiff 04_scan_changes/drivers/scsi/scsi_lib.c 05_cleanup/drivers/scsi/scsi_lib.c
--- 04_scan_changes/drivers/scsi/scsi_lib.c Wed Apr 9 12:39:22 2003
+++ 05_cleanup/drivers/scsi/scsi_lib.c Wed Apr 9 12:39:32 2003
@@ -411,7 +411,7 @@ static void scsi_single_lun_run(struct s
*/
void scsi_queue_next_request(request_queue_t *q, struct scsi_cmnd *cmd)
{
- struct scsi_device *sdev, *sdev2;
+ struct scsi_device *sdev;
struct Scsi_Host *shost;
unsigned long flags;
@@ -460,14 +460,14 @@ void scsi_queue_next_request(request_que
* scsi_request_fn must get the host_lock before checking
* or modifying starved_list or starved_entry.
*/
- sdev2 = list_entry(shost->starved_list.next,
+ sdev = list_entry(shost->starved_list.next,
struct scsi_device, starved_entry);
- list_del_init(&sdev2->starved_entry);
+ list_del_init(&sdev->starved_entry);
spin_unlock_irqrestore(shost->host_lock, flags);
- spin_lock_irqsave(sdev2->request_queue->queue_lock, flags);
- __blk_run_queue(sdev2->request_queue);
- spin_unlock_irqrestore(sdev2->request_queue->queue_lock, flags);
+ spin_lock_irqsave(sdev->request_queue->queue_lock, flags);
+ __blk_run_queue(sdev->request_queue);
+ spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
spin_lock_irqsave(shost->host_lock, flags);
if (unlikely(!list_empty(&sdev->starved_entry)))
@@ -1123,15 +1123,7 @@ static inline int scsi_host_queue_ready(
return 0;
if ((shost->can_queue > 0 && shost->host_busy >= shost->can_queue) ||
shost->host_blocked || shost->host_self_blocked) {
- SCSI_LOG_MLQUEUE(3,
- printk("add starved dev <%d,%d,%d,%d>; host "
- "limit %d, busy %d, blocked %d selfblocked %d\n",
- sdev->host->host_no, sdev->channel,
- sdev->id, sdev->lun,
- shost->can_queue, shost->host_busy,
- shost->host_blocked, shost->host_self_blocked));
- list_add_tail(&sdev->starved_entry,
- &shost->starved_list);
+ list_add_tail(&sdev->starved_entry, &shost->starved_list);
return 0;
}
prev parent reply other threads:[~2003-04-09 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-09 23:46 [patch] 1/5 scsi-locking-2.5 single_lun store scsi_device pointer Patrick Mansfield
2003-04-09 23:47 ` [patch] 2/5 scsi-locking-2.5 remove lock hierarchy Patrick Mansfield
2003-04-09 23:47 ` [patch] 3/5 scsi-locking-2.5 prevent looping when processing starved queues Patrick Mansfield
2003-04-09 23:47 ` [patch] 4/5 scsi-locking-2.5 list_del starved_entry plus use GFP_ATOMIC Patrick Mansfield
2003-04-09 23:48 ` Patrick Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030409164820.E23701@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox