From: Christoph Hellwig <hch@lst.de>
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] kill ASSERT_LOCK
Date: Mon, 21 Apr 2003 12:00:00 +0200 [thread overview]
Message-ID: <20030421120000.C24845@lst.de> (raw)
There's just one user left, and that one is in aha152x.c and thus
clearly bogus..
--- 1.27/drivers/scsi/aha152x.c Thu Mar 27 09:31:56 2003
+++ edited/drivers/scsi/aha152x.c Mon Apr 21 10:08:55 2003
@@ -1379,8 +1379,6 @@
*/
static int setup_expected_interrupts(struct Scsi_Host *shpnt)
{
- ASSERT_LOCK(&QLOCK,1);
-
if(CURRENT_SC) {
CURRENT_SC->SCp.phase |= 1 << 16;
--- 1.73/drivers/scsi/scsi.h Fri Apr 18 11:58:55 2003
+++ edited/drivers/scsi/scsi.h Mon Apr 21 10:10:01 2003
@@ -87,21 +87,6 @@
#endif
/*
- * Used for debugging the new queueing code. We want to make sure
- * that the lock state is consistent with design. Only do this in
- * the user space simulator.
- */
-#define ASSERT_LOCK(_LOCK, _COUNT)
-
-#if defined(CONFIG_SMP) && defined(CONFIG_USER_DEBUG)
-#undef ASSERT_LOCK
-#define ASSERT_LOCK(_LOCK,_COUNT) \
- { if( (_LOCK)->lock != _COUNT ) \
- panic("Lock count inconsistent %s %d\n", __FILE__, __LINE__); \
- }
-#endif
-
-/*
* Use these to separate status msg and our bytes
*
* These are set by:
reply other threads:[~2003-04-21 9:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030421120000.C24845@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox