From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Christoph Hellwig <hch@lst.de>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] proper replacements for ->proc_info
Date: Wed, 23 Apr 2003 21:39:36 +0200 [thread overview]
Message-ID: <20030423213936.B19094@lst.de> (raw)
In-Reply-To: <1051126145.1970.7.camel@mulgrave>; from James.Bottomley@SteelEye.com on Wed, Apr 23, 2003 at 03:29:01PM -0400
On Wed, Apr 23, 2003 at 03:29:01PM -0400, James Bottomley wrote:
> On Wed, 2003-04-23 at 15:21, Christoph Hellwig wrote:
> > Two new host template methods:
> >
> > int (* show_info)(struct Scsi_Host *, struct seq_file *);
> > int (* store_info)(struct Scsi_Host *, const char *, size_t);
>
>
> Well, this does look good, but by extension we could use something like
> this as a generic way to ship information to and from sysfs as well.
>
> How about adding a "char *property" qualifier? If it's null you just
> dump the whole lot (for /proc) but if it has a value, it's that specific
> property from sysfs.
For store_info? I don't think that's a good idea - most users of
store_info should really be converted to sysfs insead, but this
would break all kinds of existing apps. So we should add it but not
rip out the procfs support. Mixing up procfs and sysfs code isn't
a good idea anyway - this will lead to overloaded APIs again.
next prev parent reply other threads:[~2003-04-23 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 19:21 [PATCH] proper replacements for ->proc_info Christoph Hellwig
2003-04-23 19:29 ` James Bottomley
2003-04-23 19:39 ` Christoph Hellwig [this message]
2003-04-25 10:27 ` Christoph Hellwig
2003-04-25 10:41 ` viro
2003-04-25 10:59 ` Christoph Hellwig
2003-04-25 14:52 ` Christoph Hellwig
2003-04-25 15:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030423213936.B19094@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox