Re: [PATCH] proper replacements for ->proc_info

Christoph Hellwig
2003-04-25T15:04:54Z

On Fri, Apr 25, 2003 at 04:52:52PM +0200, Christoph Hellwig wrote:
> On Fri, Apr 25, 2003 at 12:59:18PM +0200, Christoph Hellwig wrote:
> > > And that loop is protected by ...?
> >
> > The right lock would be sdev->list_lock.
>
> Actually it would probably be host->host_lock, not a per-sdev lock
> of course. Locking down the my_device traversal is on my TODO
> list but a separate thing, though.

Oh, well.

Digging through all the (ab)users of ->my_devices I start to develop
a really strong favour of just nuking /proc/scsi/<driver>/* stuff
entirely. There's really not much in there that shouldn't better be
done in sysfs.