From: Christoph Hellwig <hch@lst.de>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] proper replacements for ->proc_info
Date: Fri, 25 Apr 2003 17:17:01 +0200 [thread overview]
Message-ID: <20030425171701.B8222@lst.de> (raw)
In-Reply-To: <20030425165252.A7951@lst.de>; from hch@lst.de on Fri, Apr 25, 2003 at 04:52:52PM +0200
On Fri, Apr 25, 2003 at 04:52:52PM +0200, Christoph Hellwig wrote:
> On Fri, Apr 25, 2003 at 12:59:18PM +0200, Christoph Hellwig wrote:
> > > And that loop is protected by ...?
> >
> > The right lock would be sdev->list_lock.
>
> Actually it would probably be host->host_lock, not a per-sdev lock
> of course. Locking down the my_device traversal is on my TODO
> list but a separate thing, though.
Oh, well.
Digging through all the (ab)users of ->my_devices I start to develop
a really strong favour of just nuking /proc/scsi/<driver>/* stuff
entirely. There's really not much in there that shouldn't better be
done in sysfs.
prev parent reply other threads:[~2003-04-25 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 19:21 [PATCH] proper replacements for ->proc_info Christoph Hellwig
2003-04-23 19:29 ` James Bottomley
2003-04-23 19:39 ` Christoph Hellwig
2003-04-25 10:27 ` Christoph Hellwig
2003-04-25 10:41 ` viro
2003-04-25 10:59 ` Christoph Hellwig
2003-04-25 14:52 ` Christoph Hellwig
2003-04-25 15:17 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030425171701.B8222@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox