From: Christoph Hellwig <hch@lst.de>
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] use scsi_report_bus_reset() in scsi_erroc.c
Date: Sun, 27 Apr 2003 13:42:54 +0200 [thread overview]
Message-ID: <20030427134254.A27685@lst.de> (raw)
Currently scsi_error.c has two opencoded copies for
scsi_report_bus_reset. Get rid of them.
--- 1.48/drivers/scsi/scsi_error.c Mon Apr 21 10:17:33 2003
+++ edited/drivers/scsi/scsi_error.c Sun Apr 27 10:46:14 2003
@@ -916,7 +913,6 @@
**/
static int scsi_try_bus_reset(struct scsi_cmnd *scmd)
{
- struct scsi_device *sdev;
unsigned long flags;
int rtn;
@@ -934,16 +930,9 @@
if (rtn == SUCCESS) {
scsi_sleep(BUS_RESET_SETTLE_TIME);
- /*
- * Mark all affected devices to expect a unit attention.
- */
- list_for_each_entry(sdev, &scmd->device->host->my_devices,
- siblings)
- if (scmd->device->channel == sdev->channel) {
- sdev->was_reset = 1;
- sdev->expecting_cc_ua = 1;
- }
+ scsi_report_bus_reset(scmd->device->host, scmd->device->channel);
}
+
return rtn;
}
@@ -953,7 +942,6 @@
**/
static int scsi_try_host_reset(struct scsi_cmnd *scmd)
{
- struct scsi_device *sdev;
unsigned long flags;
int rtn;
@@ -971,16 +959,9 @@
if (rtn == SUCCESS) {
scsi_sleep(HOST_RESET_SETTLE_TIME);
- /*
- * Mark all affected devices to expect a unit attention.
- */
- list_for_each_entry(sdev, &scmd->device->host->my_devices,
- siblings)
- if (scmd->device->channel == sdev->channel) {
- sdev->was_reset = 1;
- sdev->expecting_cc_ua = 1;
- }
+ scsi_report_bus_reset(scmd->device->host, scmd->device->channel);
}
+
return rtn;
}
reply other threads:[~2003-04-27 11:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030427134254.A27685@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox