* unchecked_isa_dma on sparcv9
@ 2003-04-29 8:19 Christoph Hellwig
2003-04-29 7:15 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2003-04-29 8:19 UTC (permalink / raw)
To: davem; +Cc: linux-scsi
drivers/scsi/pluto.c contains the following code:
#ifdef __sparc_v9__
host->unchecked_isa_dma = 1;
#endif
The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA
flag to certain memory allocations, but IIRC __GFP_DMA is a noop on
sparcv9. So what is this supposed to do?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unchecked_isa_dma on sparcv9
2003-04-29 8:19 unchecked_isa_dma on sparcv9 Christoph Hellwig
@ 2003-04-29 7:15 ` David S. Miller
2003-04-29 10:50 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-04-29 7:15 UTC (permalink / raw)
To: hch; +Cc: linux-scsi
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 29 Apr 2003 10:19:25 +0200
drivers/scsi/pluto.c contains the following code:
#ifdef __sparc_v9__
host->unchecked_isa_dma = 1;
#endif
The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA
flag to certain memory allocations, but IIRC __GFP_DMA is a noop on
sparcv9. So what is this supposed to do?
It's bogus, delete it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unchecked_isa_dma on sparcv9
2003-04-29 7:15 ` David S. Miller
@ 2003-04-29 10:50 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2003-04-29 10:50 UTC (permalink / raw)
To: David S. Miller, James.Bottomley; +Cc: linux-scsi
On Tue, Apr 29, 2003 at 12:15:11AM -0700, David S. Miller wrote:
> The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA
> flag to certain memory allocations, but IIRC __GFP_DMA is a noop on
> sparcv9. So what is this supposed to do?
>
> It's bogus, delete it.
James, could you please apply the following patch?
--- 1.10/drivers/scsi/pluto.c Thu Feb 20 14:26:15 2003
+++ edited/drivers/scsi/pluto.c Tue Apr 29 11:27:54 2003
@@ -246,11 +246,6 @@
host->max_channel = inq->channels;
host->irq = fc->irq;
-#ifdef __sparc_v9__
- host->unchecked_isa_dma = 1;
-#endif
-
-
fc->channels = inq->channels + 1;
fc->targets = inq->targets;
fc->ages = ages;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-04-29 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-29 8:19 unchecked_isa_dma on sparcv9 Christoph Hellwig
2003-04-29 7:15 ` David S. Miller
2003-04-29 10:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox