From: Tim Pepper <tpepper@vato.org>
To: James Bottomley <James.Bottomley@steeleye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Jens Axboe <axboe@suse.de>,
olh@suse.de
Subject: Re: Bad reactions to QUEUE FULL
Date: Wed, 30 Apr 2003 09:13:35 -0700 [thread overview]
Message-ID: <20030430091335.A14743@jose.vato.org> (raw)
In-Reply-To: <20030430160851.GA2350@beaverton.ibm.com>; from andmike@us.ibm.com on Wed, Apr 30, 2003 at 09:08:51AM -0700
Thanks Mike! I'll run with this and see what happens. Should I do it instead of
the one restoring the old direction?
Since it sounds LLDD related I'll bounce detailed trace info from each of
those drivers to the vendors for comment.
Thanks!
Tim
>
> --- linux-2.4/drivers/scsi/scsi_lib.c Wed Apr 30 09:04:16 2003
> +++ linux-2.4-p/drivers/scsi/scsi_lib.c Wed Apr 30 09:04:17 2003
> @@ -256,6 +256,17 @@
> if (SCpnt != NULL) {
>
> /*
> + * This is a work around for a case where this Scsi_Cmnd
> + * may have been through the busy retry paths already. We
> + * clear the special flag and try to restore the
> + * read/write request cmd value.
> + */
> + if (SCpnt->request.cmd == SPECIAL)
> + SCpnt->request.cmd =
> + (SCpnt->sc_data_direction ==
> + SCSI_DATA_WRITE) ? WRITE : READ;
> +
> + /*
> * For some reason, we are not done with this request.
> * This happens for I/O errors in the middle of the request,
> * in which case we need to request the blocks that come after
--
*********************************************************
* tpepper@vato dot org * Venimus, Vidimus, *
* http://www.vato.org/~tpepper * Dolavimus *
*********************************************************
next prev parent reply other threads:[~2003-04-30 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-30 5:02 Bad reactions to QUEUE FULL Tim Pepper
2003-04-30 14:58 ` James Bottomley
2003-04-30 16:08 ` Mike Anderson
2003-04-30 16:13 ` Tim Pepper [this message]
2003-04-30 16:51 ` Mike Anderson
2003-05-05 4:09 ` Tim Pepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030430091335.A14743@jose.vato.org \
--to=tpepper@vato.org \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox