Re: Bad reactions to QUEUE FULL

[Mike Anderson <andmike@us.ibm.com>]

You should not need the previous patch you posted.

As James stated I would be suspicious about only restoring this one field
in the command.

The side effect of the work around patch is that sd_init_command (if you
where doing IO to sd) will be called again on the command and
sc_data_direction will get set.

Tim Pepper [tpepper@vato.org] wrote:
> Thanks Mike!  I'll run with this and see what happens.  Should I do it instead of
> the one restoring the old direction?
> 
> Since it sounds LLDD related I'll bounce detailed trace info from each of
> those drivers to the vendors for comment.
> 
> Thanks!
> 
> Tim
> 
> > 
> > --- linux-2.4/drivers/scsi/scsi_lib.c		Wed Apr 30 09:04:16 2003
> > +++ linux-2.4-p/drivers/scsi/scsi_lib.c		Wed Apr 30 09:04:17 2003
> > @@ -256,6 +256,17 @@
> >  	if (SCpnt != NULL) {
> >  
> >  		/*
> > +		 * This is a work around for a case where this Scsi_Cmnd
> > +		 * may have been through the busy retry paths already. We
> > +		 * clear the special flag and try to restore the
> > +		 * read/write request cmd value.
> > +		 */
> > +		if (SCpnt->request.cmd == SPECIAL)
> > +			SCpnt->request.cmd = 
> > +				(SCpnt->sc_data_direction ==
> > +				 SCSI_DATA_WRITE) ? WRITE : READ;
> > +
> > +		/*
> >  		 * For some reason, we are not done with this request.
> >  		 * This happens for I/O errors in the middle of the request,
> >  		 * in which case we need to request the blocks that come after
> 
> -- 
> *********************************************************
> *  tpepper@vato dot org             * Venimus, Vidimus, *
> *  http://www.vato.org/~tpepper     * Dolavimus         *
> *********************************************************
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-andmike
--
Michael Anderson
andmike@us.ibm.com